Re: [FFmpeg-devel] [PATCH] lavfi/eq: factorize code in process_command through a macro

2015-03-20 Thread Stefano Sabatini
On date Tuesday 2015-03-17 12:46:32 +0100, Michael Niedermayer encoded: On Sun, Mar 15, 2015 at 02:59:58PM +0100, Stefano Sabatini wrote: On date Friday 2015-03-13 20:05:35 +0100, Michael Niedermayer encoded: On Fri, Mar 13, 2015 at 05:16:53PM +0100, Stefano Sabatini wrote: ---

Re: [FFmpeg-devel] [PATCH] lavfi/eq: factorize code in process_command through a macro

2015-03-17 Thread Michael Niedermayer
On Sun, Mar 15, 2015 at 02:59:58PM +0100, Stefano Sabatini wrote: On date Friday 2015-03-13 20:05:35 +0100, Michael Niedermayer encoded: On Fri, Mar 13, 2015 at 05:16:53PM +0100, Stefano Sabatini wrote: --- libavfilter/vf_eq.c | 56

Re: [FFmpeg-devel] [PATCH] lavfi/eq: factorize code in process_command through a macro

2015-03-15 Thread Stefano Sabatini
On date Friday 2015-03-13 20:05:35 +0100, Michael Niedermayer encoded: On Fri, Mar 13, 2015 at 05:16:53PM +0100, Stefano Sabatini wrote: --- libavfilter/vf_eq.c | 56 ++--- 1 file changed, 15 insertions(+), 41 deletions(-) i would be

Re: [FFmpeg-devel] [PATCH] lavfi/eq: factorize code in process_command through a macro

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 05:16:53PM +0100, Stefano Sabatini wrote: --- libavfilter/vf_eq.c | 56 ++--- 1 file changed, 15 insertions(+), 41 deletions(-) i would be more in favor of a function than a macro but LGTM either way, macros are harder

[FFmpeg-devel] [PATCH] lavfi/eq: factorize code in process_command through a macro

2015-03-13 Thread Stefano Sabatini
--- libavfilter/vf_eq.c | 56 ++--- 1 file changed, 15 insertions(+), 41 deletions(-) diff --git a/libavfilter/vf_eq.c b/libavfilter/vf_eq.c index 980e9ca..e1aa206 100644 --- a/libavfilter/vf_eq.c +++ b/libavfilter/vf_eq.c @@ -282,48 +282,22 @@