Re: [FFmpeg-devel] [PATCH] lavfi/vf_mpdecimate: remove request_frame().

2015-11-30 Thread Michael Niedermayer 
On Sun, Nov 29, 2015 at 01:36:48PM +0100, Nicolas George wrote:
> It is no longer needed since looping is not necessary.
> 
> Signed-off-by: Nicolas George 
> ---
>  libavfilter/vf_mpdecimate.c | 14 --
>  1 file changed, 14 deletions(-)
> 
> 
> Passes the FATE test (the one that is broken for windows).
> 
> This is the last filter that needed updatint.

technically this LGTM

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavfi/vf_mpdecimate: remove request_frame().

2015-11-29 Thread Ganesh Ajjanagadde 
On Sun, Nov 29, 2015 at 7:36 AM, Nicolas George  wrote:
> It is no longer needed since looping is not necessary.
>
> Signed-off-by: Nicolas George 
> ---
>  libavfilter/vf_mpdecimate.c | 14 --
>  1 file changed, 14 deletions(-)
>
>
> Passes the FATE test (the one that is broken for windows).
>
> This is the last filter that needed updatint.

Trivial comment: updatint -> updating.
Can't give a technical review.

[...]
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] lavfi/vf_mpdecimate: remove request_frame().

2015-11-29 Thread Nicolas George 
It is no longer needed since looping is not necessary.

Signed-off-by: Nicolas George 
---
 libavfilter/vf_mpdecimate.c | 14 --
 1 file changed, 14 deletions(-)


Passes the FATE test (the one that is broken for windows).

This is the last filter that needed updatint.


diff --git a/libavfilter/vf_mpdecimate.c b/libavfilter/vf_mpdecimate.c
index 25efacf..e0d75e0 100644
--- a/libavfilter/vf_mpdecimate.c
+++ b/libavfilter/vf_mpdecimate.c
@@ -221,19 +221,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *cur)
 return 0;
 }
 
-static int request_frame(AVFilterLink *outlink)
-{
-DecimateContext *decimate = outlink->src->priv;
-AVFilterLink *inlink = outlink->src->inputs[0];
-int ret;
-
-do {
-ret = ff_request_frame(inlink);
-} while (decimate->drop_count > 0 && ret >= 0);
-
-return ret;
-}
-
 static const AVFilterPad mpdecimate_inputs[] = {
 {
 .name = "default",
@@ -248,7 +235,6 @@ static const AVFilterPad mpdecimate_outputs[] = {
 {
 .name  = "default",
 .type  = AVMEDIA_TYPE_VIDEO,
-.request_frame = request_frame,
 },
 { NULL }
 };
-- 
2.6.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel