Re: [FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-26 Thread Clément Bœsch
On Mon, Apr 23, 2018 at 02:13:41AM +0200, Michael Niedermayer wrote: [...] > doesnt document the AVERROR case > added > should be ok otherwise, no more comments from me > thx, applied -- Clément B. signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-22 Thread Michael Niedermayer
On Sun, Apr 22, 2018 at 09:33:04AM +0200, Clément Bœsch wrote: > On Sun, Apr 22, 2018 at 02:51:16AM +0100, Rostislav Pehlivanov wrote: > [...] > > I think av_thread_message_queue_elems would be a better name, had to think > > for a good period of time what "nelem" meant. > > I'm afraid of

Re: [FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-22 Thread Clément Bœsch
On Sun, Apr 22, 2018 at 12:33:14PM +0200, Marton Balint wrote: > > > On Sun, 22 Apr 2018, Clément Bœsch wrote: > > > On Sun, Apr 22, 2018 at 02:51:16AM +0100, Rostislav Pehlivanov wrote: > > [...] > > > I think av_thread_message_queue_elems would be a better name, had to think > > > for a good

Re: [FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-22 Thread Marton Balint
On Sun, 22 Apr 2018, Clément Bœsch wrote: On Sun, Apr 22, 2018 at 02:51:16AM +0100, Rostislav Pehlivanov wrote: [...] I think av_thread_message_queue_elems would be a better name, had to think for a good period of time what "nelem" meant. I'm afraid of "queue_elems" implying "queuing

Re: [FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-22 Thread Clément Bœsch
On Sun, Apr 22, 2018 at 02:51:16AM +0100, Rostislav Pehlivanov wrote: [...] > I think av_thread_message_queue_elems would be a better name, had to think > for a good period of time what "nelem" meant. I'm afraid of "queue_elems" implying "queuing elements" so I went for the more explicit

Re: [FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-21 Thread Rostislav Pehlivanov
On 21 April 2018 at 20:51, Clément Bœsch wrote: > --- > Been away from FFmpeg for way too long. Hope this patch get me back on > track. Feel free to nitpick on the name. > --- > doc/APIchanges | 3 +++ > libavutil/threadmessage.c | 9 + >

Re: [FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-21 Thread Michael Niedermayer
On Sat, Apr 21, 2018 at 09:51:37PM +0200, Clément Bœsch wrote: > --- > Been away from FFmpeg for way too long. Hope this patch get me back on > track. Feel free to nitpick on the name. > --- > doc/APIchanges | 3 +++ > libavutil/threadmessage.c | 9 + >

[FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-21 Thread Clément Bœsch
--- Been away from FFmpeg for way too long. Hope this patch get me back on track. Feel free to nitpick on the name. --- doc/APIchanges | 3 +++ libavutil/threadmessage.c | 9 + libavutil/threadmessage.h | 5 + libavutil/version.h|