Re: [FFmpeg-devel] [PATCH] libavcodec/util: Fix timebase overflow check

2016-01-27 Thread Michael Niedermayer
On Wed, Jan 27, 2016 at 10:04:06PM +, Derek Buitenhuis wrote: > On 1/27/2016 10:03 PM, Michael Niedermayer wrote: > > is the avctx->ticks_per_frame != 0 check needed? > > I have no idea, actually. i think its not needed [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC78

Re: [FFmpeg-devel] [PATCH] libavcodec/util: Fix timebase overflow check

2016-01-27 Thread Derek Buitenhuis
On 1/27/2016 10:03 PM, Michael Niedermayer wrote: > is the avctx->ticks_per_frame != 0 check needed? I have no idea, actually. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavcodec/util: Fix timebase overflow check

2016-01-27 Thread Derek Buitenhuis
On 1/27/2016 9:13 PM, Derek Buitenhuis wrote: > It could accidentally divide by zero if num was zero. > > Signed-off-by: Derek Buitenhuis > --- > libavcodec/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) [21:58] <@nevcairiel> Daemon404: you should push that diff-by-zero patch,

Re: [FFmpeg-devel] [PATCH] libavcodec/util: Fix timebase overflow check

2016-01-27 Thread Michael Niedermayer
On Wed, Jan 27, 2016 at 09:13:19PM +, Derek Buitenhuis wrote: > It could accidentally divide by zero if num was zero. > > Signed-off-by: Derek Buitenhuis > --- > libavcodec/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils

[FFmpeg-devel] [PATCH] libavcodec/util: Fix timebase overflow check

2016-01-27 Thread Derek Buitenhuis
It could accidentally divide by zero if num was zero. Signed-off-by: Derek Buitenhuis --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 13ee243..491d8ea 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c