Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

On Wed, Jul 06, 2016 at 03:01:00PM +0200, Paul B Mahol wrote: > On 7/5/16, Burt P. wrote: > > Attached is the fourth version of this patch. I've reworked it > > a bit to make it cleaner and provide more interesting/useful > > information. Also, I've updated the documentation. >

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

On 7/5/16, Burt P. wrote: > Attached is the fourth version of this patch. I've reworked it > a bit to make it cleaner and provide more interesting/useful > information. Also, I've updated the documentation. > This includes the fix to low-level gain adjustment. > > Thanks. >

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

Attached is the fourth version of this patch. I've reworked it a bit to make it cleaner and provide more interesting/useful information. Also, I've updated the documentation. This includes the fix to low-level gain adjustment. Thanks. From 328b75b0abbc1e760a115c98d6f43dc6ff9a8fa1 Mon Sep 17

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

I've attached a third attempt at this patch with all the suggestions by Carl Eugen Hoyos and Moritz Barsnick, including converting the UPDATE_INFO macro into a function, and some more comments and little fixes. Thanks. From 2dbbfc0cea83b769b5b02eecc5ec3dabc477457b Mon Sep 17 00:00:00 2001 From:

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

Thanks. I've sent a new version of the patch in reply to Carl Eugen Hoyos, and using git send-email this time, but I saw this message and included most of the things you mentioned. I'm still getting used to this. Anyway, I am curious why both of you think UPDATE_INFO should not remain a macro? It

[FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

The new HDCD filter really does nothing to show that it is working or that HDCD control information was even detected in the stream. This patch collects information about the decode, like which features were used, and reports it to the user at the end. Signed-off-by: Burt P ---

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

Burt P. gmail.com> writes: > +/* For user information/stats, pulled up into HDCDContext > + * by filter_frame() */ > +int _hdcd_detected; No leading underscores please, same below. [...] > +/* update the user info/flags */ > +#define UPDATE_INFO(s,pe,tg,tf) I believe this should

[FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

The new HDCD filter really does nothing to show that it is working or that HDCD control information was even detected in the stream. This patch collects information about the decode, like which features were used, and reports it to the user at the end. First patch I've ever tried to submit to