Re: [FFmpeg-devel] [PATCH] libavfilter/opencl.h: Add macro for setting opencl kernel

2018-06-17 Thread Mark Thompson
On 15/06/18 03:55, Danil Iashchenko wrote: > --- > > Hi! > I like your idea with OCL_FAIL_ON_ERR(), but still do not know which one is > better. > My idea relies on fact, that there are only few OpenCL functions which are > used multiple times in filters: > clSetKernelArg, clCreateKernel(in

[FFmpeg-devel] [PATCH] libavfilter/opencl.h: Add macro for setting opencl kernel

2018-06-14 Thread Danil Iashchenko
--- Hi! I like your idea with OCL_FAIL_ON_ERR(), but still do not know which one is better. My idea relies on fact, that there are only few OpenCL functions which are used multiple times in filters: clSetKernelArg, clCreateKernel(in case when there are multiple kernels) and maybe

Re: [FFmpeg-devel] [PATCH] libavfilter/opencl.h: Add macro for setting opencl kernel

2018-06-12 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Danil Iashchenko > Sent: Tuesday, June 12, 2018 5:39 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Danil Iashchenko > Subject: [FFmpeg-devel] [PATCH] libavfilter/opencl.h:

[FFmpeg-devel] [PATCH] libavfilter/opencl.h: Add macro for setting opencl kernel

2018-06-11 Thread Danil Iashchenko
--- libavfilter/opencl.h| 15 ++ libavfilter/vf_convolution_opencl.c | 43 libavfilter/vf_overlay_opencl.c | 44 +++- libavfilter/vf_unsharp_opencl.c | 57 ++--- 4 files changed,

Re: [FFmpeg-devel] [PATCH] libavfilter/opencl.h: Add macro for setting opencl kernel

2018-06-05 Thread Mark Thompson
On 04/06/18 01:03, Danil Iashchenko wrote: > Fixed, thanks! > Also implemented macro for other filters: avgblur_opencl, convolution_opencl, > unsharp_opencl, overlay_opencl. > > --- ^ When you add extra commentary to an email, put it after this line. (What you've written here ends up in the

[FFmpeg-devel] [PATCH] libavfilter/opencl.h: Add macro for setting opencl kernel

2018-06-03 Thread Danil Iashchenko
Fixed, thanks! Also implemented macro for other filters: avgblur_opencl, convolution_opencl, unsharp_opencl, overlay_opencl. --- libavfilter/opencl.h| 13 + libavfilter/vf_avgblur_opencl.c | 48 --- libavfilter/vf_convolution_opencl.c | 43

Re: [FFmpeg-devel] [PATCH] libavfilter/opencl.h: Add macro for setting opencl kernel arguments

2018-06-03 Thread Mark Thompson
On 02/06/18 17:58, Danil Iashchenko wrote: > --- > libavfilter/opencl.h| 13 +++ > libavfilter/vf_convolution_opencl.c | 43 > ++--- > 2 files changed, 19 insertions(+), 37 deletions(-) Yeah, this is nicer. > diff --git

[FFmpeg-devel] [PATCH] libavfilter/opencl.h: Add macro for setting opencl kernel arguments

2018-06-02 Thread Danil Iashchenko
--- libavfilter/opencl.h| 13 +++ libavfilter/vf_convolution_opencl.c | 43 ++--- 2 files changed, 19 insertions(+), 37 deletions(-) diff --git a/libavfilter/opencl.h b/libavfilter/opencl.h index c0a4519..16cdfbe 100644 ---