Re: [FFmpeg-devel] [PATCH] libavformat/dnxhddec added support for raw 444 and dnxhr formats

2016-02-08 Thread Christophe Gisquet
Hi, 2016-02-08 8:15 GMT+01:00 Christophe Gisquet : > At this point, I'd say the encoder would better use that prefix. > That's what the attached patch does (rebased but not tested). You may > consider building on top of it for that purpose. Which I haven't

Re: [FFmpeg-devel] [PATCH] libavformat/dnxhddec added support for raw 444 and dnxhr

2016-02-08 Thread Michael Niedermayer
On Sun, Feb 07, 2016 at 05:31:40PM -0800, Mark Reid wrote: > Hi, > This patch enable demuxing of raw 444 and dnxhr streams. > To generate a raw stream of dnxhr (since there is no encoder support yet) > ffmpeg -i fate-suite/dnxhd/dnxhr444_cid1270.mov -an -vcodec copy out.dnxhd > ffplay out.dnxhd

Re: [FFmpeg-devel] [PATCH] libavformat/dnxhddec added support for raw 444 and dnxhr formats

2016-02-08 Thread Mark Reid
On Mon, Feb 8, 2016 at 1:25 AM, Christophe Gisquet wrote: > Hi, > > 2016-02-08 8:15 GMT+01:00 Christophe Gisquet : >> At this point, I'd say the encoder would better use that prefix. >> That's what the attached patch does (rebased but

Re: [FFmpeg-devel] [PATCH] libavformat/dnxhddec added support for raw 444 and dnxhr formats

2016-02-08 Thread Christophe Gisquet
Hi, 2016-02-09 6:27 GMT+01:00 Mark Reid : [...] > I'm guessing its okay to > include "libavcodec/dnxhddata.h" in something thats in libavformat > then? movenc.c uses those prefixes too. Argh, nice catch, you can't use the the content of ff_dnxhd_headers there, which is the

Re: [FFmpeg-devel] [PATCH] libavformat/dnxhddec added support for raw 444 and dnxhr formats

2016-02-08 Thread Carl Eugen Hoyos
Mark Reid gmail.com> writes: > I'm guessing its okay to include "libavcodec/dnxhddata.h" > in something thats in libavformat then? Yes, it is ok to include headers from libavcodec in libavformat. It may be more complicated with symbols though. Carl Eugen

[FFmpeg-devel] [PATCH] libavformat/dnxhddec added support for raw 444 and dnxhr formats

2016-02-07 Thread Mark Reid
--- libavcodec/dnxhd_parser.c | 19 --- libavformat/dnxhddec.c| 14 +++--- 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/libavcodec/dnxhd_parser.c b/libavcodec/dnxhd_parser.c index fffb98f..83bfda8 100644 --- a/libavcodec/dnxhd_parser.c +++

[FFmpeg-devel] [PATCH] libavformat/dnxhddec added support for raw 444 and dnxhr

2016-02-07 Thread Mark Reid
Hi, This patch enable demuxing of raw 444 and dnxhr streams. To generate a raw stream of dnxhr (since there is no encoder support yet) ffmpeg -i fate-suite/dnxhd/dnxhr444_cid1270.mov -an -vcodec copy out.dnxhd ffplay out.dnxhd Mark Reid (1): libavformat/dnxhddec added support for raw 444 and

Re: [FFmpeg-devel] [PATCH] libavformat/dnxhddec added support for raw 444 and dnxhr formats

2016-02-07 Thread Christophe Gisquet
Hi, 2016-02-08 2:31 GMT+01:00 Mark Reid : > +static int dnxhd_is_prefix(uint64_t prefix) > +{ > + if (prefix == DNXHD_HEADER_PREFIX|| > + prefix == DNXHD_HEADER_PREFIX444 || > + prefix == DNXHD_HEADER_PREFIXHR1 || > + prefix == DNXHD_HEADER_PREFIXHR2) > +