Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: use calculated dts offset when seeking in streams

2018-03-09 Thread Sasi Inguva
Seek on files with empty edit lists is failing with this patch. For a file with empty edit of 1s. (media time: -1 , duration : 1 ) , both DTS and PTS start at 1s. Also sc->time_offset is computed as -1s. Hence when we seek to timestamp t, it will actually seek to timestamp t+1 , which is wrong

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: use calculated dts offset when seeking in streams

2018-03-07 Thread Michael Niedermayer
On Mon, Mar 05, 2018 at 03:53:04PM -0800, Sasi Inguva wrote: > This patch seems to be doing the wrong thing and breaking seek tests for us. > > As far as I understand , seeking for most containers is based on "decoding > timestamp". Unless AV_SEEK_TO_PTS flag is specified in container, which is

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: use calculated dts offset when seeking in streams

2018-03-05 Thread Sasi Inguva
This patch seems to be doing the wrong thing and breaking seek tests for us. As far as I understand , seeking for most containers is based on "decoding timestamp". Unless AV_SEEK_TO_PTS flag is specified in container, which is not for most containers and MOV. So if PTS and DTS are like such,

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: use calculated dts offset when seeking in streams

2017-10-29 Thread Michael Niedermayer
On Sun, Oct 29, 2017 at 12:11:39PM +0100, Peter Große wrote: > From: Jonas Licht > > Subtract the calculated dts offset from the requested timestamp before > seeking. This fixes an error "Error while filtering: Operation not > permitted" observed with a short file

[FFmpeg-devel] [PATCH] libavformat/mov.c: use calculated dts offset when seeking in streams

2017-10-29 Thread Peter Große
From: Jonas Licht Subtract the calculated dts offset from the requested timestamp before seeking. This fixes an error "Error while filtering: Operation not permitted" observed with a short file which contains only one key frame and starts with negative timestamps.

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: use calculated dts offset when seeking in streams

2017-10-26 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 11:08:45PM +0200, Jonas Licht wrote: > Subtract the calculated dts offset from the requested timestamp before > seeking. This fixes an error "Error while filtering: Operation not > permitted" observed with a short file which contains only one key frame > and starts with

[FFmpeg-devel] [PATCH] libavformat/mov.c: use calculated dts offset when seeking in streams

2017-06-19 Thread Jonas Licht
Subtract the calculated dts offset from the requested timestamp before seeking. This fixes an error "Error while filtering: Operation not permitted" observed with a short file which contains only one key frame and starts with negative timestamps. Then, av_index_search_timestamp() returns a valid