Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-13 Thread Mark Reid
On Fri, Mar 13, 2015 at 3:57 AM, Tomas Härdin tomas.har...@codemill.se wrote: On Fri, 2015-03-06 at 13:24 -0800, Mark Reid wrote: +static int mxf_read_indirect_value(void *arg, AVIOContext *pb, int size) +{ +MXFTaggedValue *tagged_value = arg; +uint8_t key[17]; + +if

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-13 Thread Tomas Härdin
On Fri, 2015-03-06 at 13:24 -0800, Mark Reid wrote: +static int mxf_read_indirect_value(void *arg, AVIOContext *pb, int size) +{ +MXFTaggedValue *tagged_value = arg; +uint8_t key[17]; + +if (size = 17) +return 0; + +avio_read(pb, key, 17); Really Avid, 17 byte

[FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-06 Thread Mark Reid
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 96 +--- 2 files changed, 93 insertions(+), 4 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index d9e17c6..71a4084 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@

[FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-06 Thread Mark Reid
Hi This patch enable reading of tagged values from mxf files and export the user comment tags as metadata. The tags can have arbitrary names and values. values can also have different types. I have only added support for the utf16be and utf16le types. Avid for some reason encodes tag indirect

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-06 Thread Michael Niedermayer
On Fri, Mar 06, 2015 at 01:24:35PM -0800, Mark Reid wrote: --- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 96 +--- 2 files changed, 93 insertions(+), 4 deletions(-) [...] @@ -1630,6 +1692,30 @@ static MXFStructuralComponent*