Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-07 Thread Reimar Döffinger
On 07.05.2019, at 01:33, Lynne wrote: > May 6, 2019, 11:41 PM by barsn...@gmx.net: > >> On Mon, May 06, 2019 at 02:23:26 +0200, Lynne wrote: >> >>> This allowed for the exptabs to be computed just once on startup and >>> stored in a global array. >>> >> >> I have no real understanding of

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-07 Thread Lynne
May 6, 2019, 10:26 PM by mich...@niedermayer.cc: > > also i agree with paul, the API looks good > implementation not really reviewed > > thanks > Updated the patch with the suggestions. I've changed the API to instead have a function which gives you a function pointer which you then call with

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-07 Thread Moritz Barsnick
On Tue, May 07, 2019 at 01:33:08 +0200, Lynne wrote: > May 6, 2019, 11:41 PM by barsn...@gmx.net: > > Would there be a desire for a static implementation as well, for those > > using "-enable-hardcoded-tables" (CONFIG_HARDCODED_TABLES)? Just > > wondering whether that's esoteric, optional, or

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread Lynne
May 6, 2019, 11:11 PM by jamr...@gmail.com: > On 5/6/2019 7:04 PM, Carl Eugen Hoyos wrote: > >> Am Di., 7. Mai 2019 um 00:03 Uhr schrieb James Almer <>> jamr...@gmail.com >> >> >: >> >>> >>> On 5/6/2019 6:26 PM, Michael Niedermayer wrote: >>> also i agree with

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread Lynne
May 6, 2019, 11:41 PM by barsn...@gmx.net: > On Mon, May 06, 2019 at 02:23:26 +0200, Lynne wrote: > >> This allowed for the exptabs to be computed just once on startup and >> stored in a global array. >> > > I have no real understanding of this, but: > Would there be a desire for a static

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread Moritz Barsnick
On Mon, May 06, 2019 at 02:23:26 +0200, Lynne wrote: > This allowed for the exptabs to be computed just once on startup and > stored in a global array. I have no real understanding of this, but: Would there be a desire for a static implementation as well, for those using

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread Michael Niedermayer
On Tue, May 07, 2019 at 12:15:37AM +0200, Michael Niedermayer wrote: > On Mon, May 06, 2019 at 07:02:54PM -0300, James Almer wrote: > > On 5/6/2019 6:26 PM, Michael Niedermayer wrote: > > > also i agree with paul, the API looks good > > > implementation not really reviewed > > > > I don't like

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread James Almer
On 5/6/2019 7:04 PM, Carl Eugen Hoyos wrote: > Am Di., 7. Mai 2019 um 00:03 Uhr schrieb James Almer : >> >> On 5/6/2019 6:26 PM, Michael Niedermayer wrote: >>> also i agree with paul, the API looks good >>> implementation not really reviewed >> >> I don't like the avfft_* namespace. It's unlike

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread Michael Niedermayer
On Mon, May 06, 2019 at 07:02:54PM -0300, James Almer wrote: > On 5/6/2019 6:26 PM, Michael Niedermayer wrote: > > also i agree with paul, the API looks good > > implementation not really reviewed > > I don't like the avfft_* namespace. It's unlike other modules we have. > > Since av_fft_* is

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread Carl Eugen Hoyos
Am Di., 7. Mai 2019 um 00:03 Uhr schrieb James Almer : > > On 5/6/2019 6:26 PM, Michael Niedermayer wrote: > > also i agree with paul, the API looks good > > implementation not really reviewed > > I don't like the avfft_* namespace. It's unlike other modules we have. > > Since av_fft_* is taken by

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread James Almer
On 5/6/2019 6:26 PM, Michael Niedermayer wrote: > also i agree with paul, the API looks good > implementation not really reviewed I don't like the avfft_* namespace. It's unlike other modules we have. Since av_fft_* is taken by the lavc implementation and can't be used, maybe this one could be

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread Michael Niedermayer
On Mon, May 06, 2019 at 02:23:26AM +0200, Lynne wrote: > May 5, 2019, 1:52 PM by d...@lynne.ee: > > > May 4, 2019, 10:00 PM by > d...@lynne.ee > : > > > >> May 4, 2019, 8:10 PM by > >> mich...@niedermayer.cc > >> >> > mich...@niedermayer.cc

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread Paul B Mahol
On 5/6/19, Lynne wrote: > May 5, 2019, 1:52 PM by d...@lynne.ee: > >> May 4, 2019, 10:00 PM by > d...@lynne.ee > : >> >>> May 4, 2019, 8:10 PM by > >> mich...@niedermayer.cc >>> >> > mich...@niedermayer.cc >>> >>

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-05 Thread Lynne
May 5, 2019, 1:52 PM by d...@lynne.ee: > May 4, 2019, 10:00 PM by > d...@lynne.ee > : > >> May 4, 2019, 8:10 PM by > >> mich...@niedermayer.cc >> >> > mich...@niedermayer.cc >> >> >> : >> >>> On Fri, May 03,

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-05 Thread Lynne
May 4, 2019, 10:00 PM by d...@lynne.ee: > May 4, 2019, 8:10 PM by > mich...@niedermayer.cc > > : > >> On Fri, May 03, 2019 at 09:08:57PM +0200, Lynne wrote: >> >>> This commit adds a new API to libavutil to allow for arbitrary >>> transformations >>> on various

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-04 Thread Lynne
May 4, 2019, 8:10 PM by mich...@niedermayer.cc: > On Fri, May 03, 2019 at 09:08:57PM +0200, Lynne wrote: > >> This commit adds a new API to libavutil to allow for arbitrary >> transformations >> on various types of data. >> > breaks build on mips > > CClibavutil/fft.o >

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-04 Thread Michael Niedermayer
On Fri, May 03, 2019 at 09:08:57PM +0200, Lynne wrote: > This commit adds a new API to libavutil to allow for arbitrary transformations > on various types of data. > This is a partly new implementation, with the power of two transforms taken > from libavcodec/fft_template, the 5 and 15-point FFT

[FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-03 Thread Lynne
This commit adds a new API to libavutil to allow for arbitrary transformations on various types of data. This is a partly new implementation, with the power of two transforms taken from libavcodec/fft_template, the 5 and 15-point FFT taken from mdct15, while the 3-point FFT was written from