Re: [FFmpeg-devel] [PATCH] libx264: Add option to force IDR frames

2015-08-18 Thread Michael Niedermayer
On Tue, Aug 18, 2015 at 02:00:17PM +0100, Derek Buitenhuis wrote: > Currently, when forcing an I frame, via API, or via the ffmpeg cli, > using -force_key_frames, we still let x264 decide what sort of > keyframe to user. In some cases, it is useful to be able to force > an IDR frame, e.g. for cutti

Re: [FFmpeg-devel] [PATCH] libx264: Add option to force IDR frames

2015-08-18 Thread Yusuke Nakamura
2015-08-19 0:20 GMT+09:00 Carl Eugen Hoyos : > Hendrik Leppkes gmail.com> writes: > > > Whats the other reason for forcing a keyframe, ie. > > why don't we always set IDR? > > I don't know if x264 supports it (and I wanted to ask) > but h264 reference frames can be older than the last > I-frame (

Re: [FFmpeg-devel] [PATCH] libx264: Add option to force IDR frames

2015-08-18 Thread Carl Eugen Hoyos
Hendrik Leppkes gmail.com> writes: > Whats the other reason for forcing a keyframe, ie. > why don't we always set IDR? I don't know if x264 supports it (and I wanted to ask) but h264 reference frames can be older than the last I-frame (but not older than the last IDR-frame). The I-frame is no

Re: [FFmpeg-devel] [PATCH] libx264: Add option to force IDR frames

2015-08-18 Thread Hendrik Leppkes
On Tue, Aug 18, 2015 at 5:15 PM, Derek Buitenhuis wrote: > On 8/18/2015 4:05 PM, Hendrik Leppkes wrote: >> Whats the other reason for forcing a keyframe, ie. why don't we always set >> IDR? > > The other reason would be seek points I guess? > Isn't seeking just like cutting? The decoder won't ge

Re: [FFmpeg-devel] [PATCH] libx264: Add option to force IDR frames

2015-08-18 Thread Derek Buitenhuis
On 8/18/2015 4:05 PM, Hendrik Leppkes wrote: > Whats the other reason for forcing a keyframe, ie. why don't we always set > IDR? The other reason would be seek points I guess? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.

Re: [FFmpeg-devel] [PATCH] libx264: Add option to force IDR frames

2015-08-18 Thread Hendrik Leppkes
On Tue, Aug 18, 2015 at 3:00 PM, Derek Buitenhuis wrote: > Currently, when forcing an I frame, via API, or via the ffmpeg cli, > using -force_key_frames, we still let x264 decide what sort of > keyframe to user. In some cases, it is useful to be able to force > an IDR frame, e.g. for cutting strea

[FFmpeg-devel] [PATCH] libx264: Add option to force IDR frames

2015-08-18 Thread Derek Buitenhuis
Currently, when forcing an I frame, via API, or via the ffmpeg cli, using -force_key_frames, we still let x264 decide what sort of keyframe to user. In some cases, it is useful to be able to force an IDR frame, e.g. for cutting streams. Signed-off-by: Derek Buitenhuis --- libavcodec/libx264.c |