Re: [FFmpeg-devel] [PATCH] libx264: fix -b_qfactor and -chromaoffset

2014-08-26 Thread Michael Niedermayer
On Tue, Aug 26, 2014 at 02:58:32PM +0800, Hii wrote: > Hi, > > On 2014-08-25 01:24, Michael Niedermayer wrote: > > On Sat, Aug 23, 2014 at 08:59:41PM +0800, Hii wrote: > >> Currently -b_qfactor and -chromaoffset have no effect in libx264, > >> the attached patch is an attempt to fix the issue. > >

Re: [FFmpeg-devel] [PATCH] libx264: fix -b_qfactor and -chromaoffset

2014-08-26 Thread Hii
Hi, On 2014-08-25 01:24, Michael Niedermayer wrote: > On Sat, Aug 23, 2014 at 08:59:41PM +0800, Hii wrote: >> Currently -b_qfactor and -chromaoffset have no effect in libx264, >> the attached patch is an attempt to fix the issue. >> >> Move the corresponding lines after x264_param_default_preset(

Re: [FFmpeg-devel] [PATCH] libx264: fix -b_qfactor and -chromaoffset

2014-08-24 Thread Michael Niedermayer
On Sat, Aug 23, 2014 at 08:59:41PM +0800, Hii wrote: > Currently -b_qfactor and -chromaoffset have no effect in libx264, > the attached patch is an attempt to fix the issue. > > Move the corresponding lines after x264_param_default_preset() to > prevent them being overwritten by it, make the two p

[FFmpeg-devel] [PATCH] libx264: fix -b_qfactor and -chromaoffset

2014-08-23 Thread Hii
Currently -b_qfactor and -chromaoffset have no effect in libx264, the attached patch is an attempt to fix the issue. Move the corresponding lines after x264_param_default_preset() to prevent them being overwritten by it, make the two parameters functional. Also make b_qfactor changeable by x26