Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread wm4
On Fri, 26 Feb 2016 13:17:29 +0100 Reimar Döffinger wrote: > Well, there I go, doing my own idle discussions > I just complained about ;) > > On Fri, Feb 26, 2016 at 01:00:23PM +0100, wm4 wrote: > > On Fri, 26 Feb 2016 12:19:18 +0100 > > Reimar Döffinger

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread Michael Niedermayer
On Fri, Feb 26, 2016 at 02:20:33PM +0100, Reimar Döffinger wrote: > On 26.02.2016, at 14:01, Michael Niedermayer wrote: > > > On Fri, Feb 26, 2016 at 01:17:29PM +0100, Reimar Döffinger wrote: > >> Well, there I go, doing my own idle discussions > >> I just complained

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread Reimar Döffinger
On 26.02.2016, at 14:01, Michael Niedermayer wrote: > On Fri, Feb 26, 2016 at 01:17:29PM +0100, Reimar Döffinger wrote: >> Well, there I go, doing my own idle discussions >> I just complained about ;) >> >> On Fri, Feb 26, 2016 at 01:00:23PM +0100, wm4 wrote: >>> On Fri,

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread Michael Niedermayer
On Fri, Feb 26, 2016 at 01:17:29PM +0100, Reimar Döffinger wrote: > Well, there I go, doing my own idle discussions > I just complained about ;) > > On Fri, Feb 26, 2016 at 01:00:23PM +0100, wm4 wrote: > > On Fri, 26 Feb 2016 12:19:18 +0100 > > Reimar Döffinger wrote: >

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread Reimar Döffinger
Well, there I go, doing my own idle discussions I just complained about ;) On Fri, Feb 26, 2016 at 01:00:23PM +0100, wm4 wrote: > On Fri, 26 Feb 2016 12:19:18 +0100 > Reimar Döffinger wrote: > > I am not exactly sure what their opinion is to be honest. > > However this

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread Reimar Döffinger
On Fri, Feb 26, 2016 at 12:40:19PM +0100, Clément Bœsch wrote: > On Fri, Feb 26, 2016 at 11:29:05AM +0100, wm4 wrote: > > Unfortunately I have to agree. I got some crashes in libavfilter when I > > didn't set some "unused" plane pointers to NULL. Some code is just lazy > > and checks plane

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread wm4
On Fri, 26 Feb 2016 12:19:18 +0100 Reimar Döffinger wrote: > On 26.02.2016, at 11:42, Hendrik Leppkes wrote: > > > On Fri, Feb 26, 2016 at 11:35 AM, Reimar Döffinger > > wrote: > >> On 26.02.2016, at 02:38, Michael

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread Clément Bœsch
On Fri, Feb 26, 2016 at 11:29:05AM +0100, wm4 wrote: > On Fri, 26 Feb 2016 02:38:13 +0100 > Michael Niedermayer wrote: > > > On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar Döffinger wrote: > > > We do neither document nor check such a requirement > > > and for

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread Reimar Döffinger
On 26.02.2016, at 11:42, Hendrik Leppkes wrote: > On Fri, Feb 26, 2016 at 11:35 AM, Reimar Döffinger > wrote: >> On 26.02.2016, at 02:38, Michael Niedermayer wrote: >> >>> On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread Hendrik Leppkes
On Fri, Feb 26, 2016 at 11:35 AM, Reimar Döffinger wrote: > On 26.02.2016, at 02:38, Michael Niedermayer wrote: > >> On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar Döffinger wrote: >>> We do neither document nor check such a requirement >>> and

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread Reimar Döffinger
On 26.02.2016, at 02:38, Michael Niedermayer wrote: > On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar Döffinger wrote: >> We do neither document nor check such a requirement >> and for application-provided get_buffer2 they could >> contain the result of a malloc(0) or

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-26 Thread wm4
On Fri, 26 Feb 2016 02:38:13 +0100 Michael Niedermayer wrote: > On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar Döffinger wrote: > > We do neither document nor check such a requirement > > and for application-provided get_buffer2 they could > > contain the result of a

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-25 Thread Michael Niedermayer
On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar Döffinger wrote: > We do neither document nor check such a requirement > and for application-provided get_buffer2 they could > contain the result of a malloc(0) or whatever value > they had previously. > This fixes a use-after-free in e.g. MPlayer:

[FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

2016-02-25 Thread Reimar Döffinger
We do neither document nor check such a requirement and for application-provided get_buffer2 they could contain the result of a malloc(0) or whatever value they had previously. This fixes a use-after-free in e.g. MPlayer: https://trac.mplayerhq.hu/ticket/2262 We might want to consider changing the