Re: [FFmpeg-devel] [PATCH] mov: only read e_old if there were any old streams

2016-11-01 Thread Andreas Cadhalpun
On 01.11.2016 06:32, Sasi Inguva wrote: > patch looks good to me. Thanks for the fix. Pushed. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] mov: only read e_old if there were any old streams

2016-10-31 Thread Sasi Inguva
patch looks good to me. Thanks for the fix. On Mon, Oct 31, 2016 at 5:17 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 31.10.2016 19:20, Sasi Inguva wrote: > > First of all, if nb_old == 0 i.e. there are no entries in AVIndex, then > > there is no point in calling

Re: [FFmpeg-devel] [PATCH] mov: only read e_old if there were any old streams

2016-10-31 Thread Andreas Cadhalpun
On 31.10.2016 19:20, Sasi Inguva wrote: > First of all, if nb_old == 0 i.e. there are no entries in AVIndex, then > there is no point in calling mov_fix_index function at all. So instead of > doing the above , you can directly check for st->nb_index_entries > 0 at > the top of mov_fix_index and

Re: [FFmpeg-devel] [PATCH] mov: only read e_old if there were any old streams

2016-10-31 Thread Sasi Inguva
First of all, if nb_old == 0 i.e. there are no entries in AVIndex, then there is no point in calling mov_fix_index function at all. So instead of doing the above , you can directly check for st->nb_index_entries > 0 at the top of mov_fix_index and return otherwise. Also, I don't understand how

[FFmpeg-devel] [PATCH] mov: only read e_old if there were any old streams

2016-10-30 Thread Andreas Cadhalpun
This fixes a heap buffer overflow. Signed-off-by: Andreas Cadhalpun --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 357d800..95b546e 100644 --- a/libavformat/mov.c +++