Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-18 Thread tomas . hardin
On 2015-03-17 16:13, Andreas Cadhalpun wrote: On 17.03.2015 10:17, tomas.har...@codemill.se wrote: On 2015-03-14 18:03, Andreas Cadhalpun wrote: [PATCH 2/2] mxfenc: don't try to write footer without header: +if (!mxf-header_written || +(s-oformat == ff_mxf_opatom_muxer

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-18 Thread Michael Niedermayer
On Wed, Mar 18, 2015 at 10:01:36PM +0100, Andreas Cadhalpun wrote: On 18.03.2015 16:59, tomas.har...@codemill.se wrote: On 2015-03-17 16:13, Andreas Cadhalpun wrote: On 17.03.2015 10:17, tomas.har...@codemill.se wrote: On 2015-03-14 18:03, Andreas Cadhalpun wrote: [PATCH 2/2] mxfenc:

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-17 Thread Andreas Cadhalpun
On 17.03.2015 10:17, tomas.har...@codemill.se wrote: On 2015-03-14 18:03, Andreas Cadhalpun wrote: [PATCH 2/2] mxfenc: don't try to write footer without header: +if (!mxf-header_written || +(s-oformat == ff_mxf_opatom_muxer !mxf-body_partition_offset)) { +err =

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-17 Thread tomas . hardin
On 2015-03-14 18:03, Andreas Cadhalpun wrote: On 14.03.2015 02:17, Mark Reid wrote: On Fri, Mar 13, 2015 at 6:02 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 13.03.2015 11:59, Tomas Härdin wrote: A better solution would be to figure out why mxf-body_partition_offset

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-17 Thread Michael Niedermayer
On Tue, Mar 17, 2015 at 10:17:06AM +0100, tomas.har...@codemill.se wrote: On 2015-03-14 18:03, Andreas Cadhalpun wrote: On 14.03.2015 02:17, Mark Reid wrote: On Fri, Mar 13, 2015 at 6:02 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: [...] Memleak patch is obviously OK.

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-14 Thread Andreas Cadhalpun
On 14.03.2015 02:17, Mark Reid wrote: On Fri, Mar 13, 2015 at 6:02 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 13.03.2015 11:59, Tomas Härdin wrote: A better solution would be to figure out why mxf-body_partition_offset becomes NULL so that index tables and such can

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-13 Thread Mark Reid
On Fri, Mar 13, 2015 at 6:02 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 13.03.2015 11:59, Tomas Härdin wrote: On Thu, 2015-03-12 at 17:48 +0100, Andreas Cadhalpun wrote: This fixes a crash, when trying to mux h264 into mxf_opatom. Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-13 Thread Tomas Härdin
On Thu, 2015-03-12 at 17:48 +0100, Andreas Cadhalpun wrote: This fixes a crash, when trying to mux h264 into mxf_opatom. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavformat/mxfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-13 Thread Andreas Cadhalpun
On 13.03.2015 11:59, Tomas Härdin wrote: On Thu, 2015-03-12 at 17:48 +0100, Andreas Cadhalpun wrote: This fixes a crash, when trying to mux h264 into mxf_opatom. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavformat/mxfenc.c | 2 +- 1 file changed, 1