Re: [FFmpeg-devel] [PATCH] set bitrate from rc_max_rate for duration estimation will fix ticket #3678

2014-08-21 Thread Marc-Antoine ARNAUD
I have analysed a little more of code, and in fact the duration was not present in the MXF. It's for this reason who we pass in the estimation based on the bitrate. You can see here the selection of the method: https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/utils.c#L2458 About the max

Re: [FFmpeg-devel] [PATCH] set bitrate from rc_max_rate for duration estimation will fix ticket #3678

2014-08-20 Thread Carl Eugen Hoyos
Marc-Antoine Arnaud marcantoine.arnaud at arkena.com writes: +if (st-codec-rc_max_rate 0) { +if (INT_MAX - st-codec-rc_max_rate bit_rate) { +bit_rate = 0; +break; +} +bit_rate +=

Re: [FFmpeg-devel] [PATCH] set bitrate from rc_max_rate for duration estimation will fix ticket #3678

2014-08-20 Thread Michael Niedermayer
On Wed, Aug 20, 2014 at 03:37:58PM +0200, Marc-Antoine Arnaud wrote: From: Marc-Antoine Arnaud arnaud.marcanto...@gmail.com --- libavformat/utils.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index b4ca342..738d1f0 100644 ---

Re: [FFmpeg-devel] [PATCH] set bitrate from rc_max_rate for duration estimation will fix ticket #3678

2014-08-20 Thread Marc-Antoine ARNAUD
Hi Carl, Yes I test with the attached file. The case is when the input video stream is in Mpeg2, the bitrate of the stream was setup in rc_max_rate, not in bitrate [https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/mpeg12dec.c#L1284]. For the remark you mean I can add an else if

Re: [FFmpeg-devel] [PATCH] set bitrate from rc_max_rate for duration estimation will fix ticket #3678

2014-08-20 Thread Marc-Antoine ARNAUD
Hi Michael, I agreed how we can take the information in the wrapper if it's present. In MXF case it can be done. But in other formats, this information is not necessary present ... The other possibility is to set the duration to -1 to disable print when we can't known exactly the duration.

Re: [FFmpeg-devel] [PATCH] set bitrate from rc_max_rate for duration estimation will fix ticket #3678

2014-08-20 Thread Michael Niedermayer
On Wed, Aug 20, 2014 at 08:52:09PM +0200, Marc-Antoine ARNAUD wrote: Hi Michael, I agreed how we can take the information in the wrapper if it's present. In MXF case it can be done. But in other formats, this information is not necessary present ... yes, and thus it cannot be done