Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-08 Thread Ganesh Ajjanagadde
On Sun, Nov 8, 2015 at 12:45 PM, Michael Niedermayer wrote: > On Sun, Nov 08, 2015 at 10:53:21AM -0500, Ganesh Ajjanagadde wrote: >> On Sun, Nov 8, 2015 at 7:24 AM, Derek Buitenhuis >> wrote: >> > On 11/7/2015 10:42 PM, Ganesh Ajjanagadde wrote: >> >> This is what I felt - it is an internal struc

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-08 Thread Michael Niedermayer
On Sun, Nov 08, 2015 at 10:53:21AM -0500, Ganesh Ajjanagadde wrote: > On Sun, Nov 8, 2015 at 7:24 AM, Derek Buitenhuis > wrote: > > On 11/7/2015 10:42 PM, Ganesh Ajjanagadde wrote: > >> This is what I felt - it is an internal struct, and there are explicit > >> comments in the header saying that t

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-08 Thread Ganesh Ajjanagadde
On Sun, Nov 8, 2015 at 7:24 AM, Derek Buitenhuis wrote: > On 11/7/2015 10:42 PM, Ganesh Ajjanagadde wrote: >> This is what I felt - it is an internal struct, and there are explicit >> comments in the header saying that the struct's fields are meant to be >> manipulated via the options API unlike e

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-08 Thread Derek Buitenhuis
On 11/7/2015 10:42 PM, Ganesh Ajjanagadde wrote: > This is what I felt - it is an internal struct, and there are explicit > comments in the header saying that the struct's fields are meant to be > manipulated via the options API unlike e.g libavcodec. The types were > IMHO not part of the ABI/API s

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Ganesh Ajjanagadde
On Sat, Nov 7, 2015 at 4:57 PM, Michael Niedermayer wrote: > On Sat, Nov 07, 2015 at 10:49:42PM +0100, wm4 wrote: >> On Sat, 7 Nov 2015 20:00:50 + >> Derek Buitenhuis wrote: >> >> > On 11/7/2015 7:35 PM, Paul B Mahol wrote: >> > > AFAIK changing option from int to double will break programs w

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Michael Niedermayer
On Sat, Nov 07, 2015 at 10:49:42PM +0100, wm4 wrote: > On Sat, 7 Nov 2015 20:00:50 + > Derek Buitenhuis wrote: > > > On 11/7/2015 7:35 PM, Paul B Mahol wrote: > > > AFAIK changing option from int to double will break programs which > > > assume opttions is int. > > > > Not really sure how

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread wm4
On Sat, 7 Nov 2015 20:00:50 + Derek Buitenhuis wrote: > On 11/7/2015 7:35 PM, Paul B Mahol wrote: > > AFAIK changing option from int to double will break programs which > > assume opttions is int. > > Not really sure how it could. The original range allowed was [2,16], > and using any of t

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Derek Buitenhuis
On 11/7/2015 7:35 PM, Paul B Mahol wrote: > AFAIK changing option from int to double will break programs which > assume opttions is int. Not really sure how it could. The original range allowed was [2,16], and using any of the av_opt_set functions should still work with that, no? - Derek ___

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Paul B Mahol
On 11/7/15, Derek Buitenhuis wrote: > On 11/7/2015 4:47 PM, Paul B Mahol wrote: >> I'm afraid that this can't be done this way. > > Perhaps providing more detail than HAL 9000 could > help Ganesh here. AFAIK changing option from int to double will break programs which assume opttions is int.

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Derek Buitenhuis
On 11/7/2015 4:47 PM, Paul B Mahol wrote: > I'm afraid that this can't be done this way. Perhaps providing more detail than HAL 9000 could help Ganesh here. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Paul B Mahol
On 11/7/15, Ganesh Ajjanagadde wrote: > Kaiser windows inherently don't require beta to be an integer. This was > an arbitrary restriction. Moreover, soxr does not require it, and in > fact often estimates beta to a non-integral value. > > Thus, this patch allows greater flexibility for swresample

[FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Ganesh Ajjanagadde
Kaiser windows inherently don't require beta to be an integer. This was an arbitrary restriction. Moreover, soxr does not require it, and in fact often estimates beta to a non-integral value. Thus, this patch allows greater flexibility for swresample clients. Signed-off-by: Ganesh Ajjanagadde --