Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-12-07 Thread Neil Birkbeck
On Sat, Dec 2, 2017 at 5:25 PM, Carl Eugen Hoyos wrote: > 2017-12-01 20:08 GMT+01:00 Neil Birkbeck : > > On Thu, Nov 30, 2017 at 9:52 AM, Michael Niedermayer wrote: > > >> > For that sample, I feel like it may be incorrectly tagged as pc/full. > >> >

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-12-02 Thread Carl Eugen Hoyos
2017-12-01 20:08 GMT+01:00 Neil Birkbeck : > On Thu, Nov 30, 2017 at 9:52 AM, Michael Niedermayer wrote: >> > For that sample, I feel like it may be incorrectly tagged as pc/full. >> >> is it stored in the file or taken from: >> ff_generate_avci_extradata() >> maybe

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-12-01 Thread Neil Birkbeck
On Thu, Nov 30, 2017 at 9:52 AM, Michael Niedermayer wrote: > > > Perfect, thanks Michael. Let me check those samples out. > > there are 2 more in 2939 which change: > https://trac.ffmpeg.org/ticket/2939 > It seems the swscale_unscaled code paths do not get reconfigured

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-11-30 Thread Michael Niedermayer
On Wed, Nov 29, 2017 at 08:08:40PM -0800, Neil Birkbeck wrote: > On Wed, Nov 29, 2017 at 7:40 PM, Neil Birkbeck > wrote: > > > > >> > >> If you are searching for a case where the patch makes a difference > >> one is: > >> ./ffmpeg -i ~/tickets/4493/AVCI100.mov out.nut >

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-11-29 Thread Neil Birkbeck
On Wed, Nov 29, 2017 at 7:40 PM, Neil Birkbeck wrote: > >> >> If you are searching for a case where the patch makes a difference >> one is: >> ./ffmpeg -i ~/tickets/4493/AVCI100.mov out.nut >> file should be here: >> http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket524/

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-11-29 Thread Neil Birkbeck
> > > > If you are searching for a case where the patch makes a difference > one is: > ./ffmpeg -i ~/tickets/4493/AVCI100.mov out.nut > file should be here: > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket524/ > > if you want more cases that change, ill see if i can find more > Perfect, thanks

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-11-29 Thread Michael Niedermayer
On Tue, Nov 28, 2017 at 05:14:37PM -0800, Neil Birkbeck wrote: > On higher bit depth YUV inputs with range metadata signaled as PC/full levels, > this change makes the results of scaling without explicitly > setting the input range on vf_scale as if it were explicitly set. > > For example, the

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-11-28 Thread Neil Birkbeck
On Tue, Nov 28, 2017 at 5:14 PM, Neil Birkbeck wrote: > -//The srcBpc check is possibly wrong but we seem to lack a definitive > reference to test this > -//and what we have in ticket 2939 looks better with this check > -if (need_reinit && (c->srcBpc == 8 ||

[FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-11-28 Thread Neil Birkbeck
On higher bit depth YUV inputs with range metadata signaled as PC/full levels, this change makes the results of scaling without explicitly setting the input range on vf_scale as if it were explicitly set. For example, the results with implicit color settings from the frame: -vf