Re: [FFmpeg-devel] [PATCH] tiffdec: support embedded ICC profiles

2020-01-13 Thread Lynne
Jan 13, 2020, 22:07 by derek.buitenh...@gmail.com: > On 13/01/2020 22:05, Lynne wrote: > >> bytestream2_seek returns the amount of bytes since the start of the buffer >> after seeking. It clips to the size of the buffer so you can't seek past the >> end. >> > > LGTM then. > Pushed, thanks.

Re: [FFmpeg-devel] [PATCH] tiffdec: support embedded ICC profiles

2020-01-13 Thread Derek Buitenhuis
On 13/01/2020 22:05, Lynne wrote: > bytestream2_seek returns the amount of bytes since the start of the buffer > after seeking. It clips to the size of the buffer so you can't seek past the > end. LGTM then. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] tiffdec: support embedded ICC profiles

2020-01-13 Thread Lynne
Jan 13, 2020, 20:20 by derek.buitenh...@gmail.com: > On 13/01/2020 17:50, Lynne wrote: > >> Actually the entire condition needs to be gone. count is uint32_t. The >> length is already checked below. >> Copied this from ff_tadd_shorts_metadata which has an int count. >> > > Ah. > >> And the

Re: [FFmpeg-devel] [PATCH] tiffdec: support embedded ICC profiles

2020-01-13 Thread Derek Buitenhuis
On 13/01/2020 17:50, Lynne wrote: > Actually the entire condition needs to be gone. count is uint32_t. The length > is already checked below. > Copied this from ff_tadd_shorts_metadata which has an int count. Ah. > And the offset value isn't taken into account. TIFF allows the ICC profile to >

Re: [FFmpeg-devel] [PATCH] tiffdec: support embedded ICC profiles

2020-01-13 Thread Lynne
Jan 13, 2020, 16:06 by derek.buitenh...@gmail.com: > On 10/01/2020 22:06, Lynne wrote: > >> Patch attached. >> >> Very widespread, every NASA TIFF image has an ICC profile embedded, and its >> almost never sRGB, so this is really needed for proper color display. >> > > [...] > >> --- >>

Re: [FFmpeg-devel] [PATCH] tiffdec: support embedded ICC profiles

2020-01-13 Thread Derek Buitenhuis
On 10/01/2020 22:06, Lynne wrote: > Patch attached. > > Very widespread, every NASA TIFF image has an ICC profile embedded, and its > almost never sRGB, so this is really needed for proper color display. [...] > --- > libavcodec/tiff.c | 13 + > libavcodec/tiff.h | 1 + > 2 files

[FFmpeg-devel] [PATCH] tiffdec: support embedded ICC profiles

2020-01-10 Thread Lynne
Patch attached. Very widespread, every NASA TIFF image has an ICC profile embedded, and its almost never sRGB, so this is really needed for proper color display. >From 1a3cbad82c897110e8ef221aae9733b841a443fc Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 10 Jan 2020 21:55:19 + Subject: