Re: [FFmpeg-devel] [PATCH]Do not set bitrate for DTS-HD Master and High Resolution

2015-03-19 Thread Carl Eugen Hoyos
Marcus Johnson gmail.com> writes: > That's even worse, is there any way we can fix it? No, users would be unhappy if opening a file meant reading the whole file. The following works fine here to get the actual duration of a dts-hd master stream and is twice as fast as decoding the whole file:

Re: [FFmpeg-devel] [PATCH]Do not set bitrate for DTS-HD Master and High Resolution

2015-03-18 Thread Marcus Johnson
That's even worse, is there any way we can fix it? how much effort would it require? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]Do not set bitrate for DTS-HD Master and High Resolution

2015-03-18 Thread Hendrik Leppkes
On Wed, Mar 18, 2015 at 3:40 PM, Marcus Johnson wrote: > I see, I thought it counted frames and not just multiplied the bitrate by > the number of frames. It just divides the file size by the bitrate. It doesn't count frames at all, its not equipped for that. If it were, it could provide accurate

Re: [FFmpeg-devel] [PATCH]Do not set bitrate for DTS-HD Master and High Resolution

2015-03-18 Thread Marcus Johnson
I see, I thought it counted frames and not just multiplied the bitrate by the number of frames. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]Do not set bitrate for DTS-HD Master and High Resolution

2015-03-18 Thread Michael Niedermayer
On Wed, Mar 18, 2015 at 01:21:25PM +0100, Hendrik Leppkes wrote: > On Wed, Mar 18, 2015 at 1:06 PM, Michael Niedermayer wrote: > > On Wed, Mar 18, 2015 at 07:49:46AM -0400, Marcus Johnson wrote: > >> This reminds me of another bug with DTS files, it estimates the file > >> duration by counting eac

Re: [FFmpeg-devel] [PATCH]Do not set bitrate for DTS-HD Master and High Resolution

2015-03-18 Thread Hendrik Leppkes
On Wed, Mar 18, 2015 at 1:06 PM, Michael Niedermayer wrote: > On Wed, Mar 18, 2015 at 07:49:46AM -0400, Marcus Johnson wrote: >> This reminds me of another bug with DTS files, it estimates the file >> duration by counting each frame I assume, including the HD ones resulting >> in it being massivel

Re: [FFmpeg-devel] [PATCH]Do not set bitrate for DTS-HD Master and High Resolution

2015-03-18 Thread Michael Niedermayer
On Wed, Mar 18, 2015 at 07:49:46AM -0400, Marcus Johnson wrote: > This reminds me of another bug with DTS files, it estimates the file > duration by counting each frame I assume, including the HD ones resulting > in it being massively incorrect for example here's the ffmpeg output of a > DTS-HD MA

Re: [FFmpeg-devel] [PATCH]Do not set bitrate for DTS-HD Master and High Resolution

2015-03-18 Thread Marcus Johnson
This reminds me of another bug with DTS files, it estimates the file duration by counting each frame I assume, including the HD ones resulting in it being massively incorrect for example here's the ffmpeg output of a DTS-HD MA file that's actually 98 minutes long Log: ffmpeg -i /Users/Marcus/De

Re: [FFmpeg-devel] [PATCH]Do not set bitrate for DTS-HD Master and High Resolution

2015-03-18 Thread Hendrik Leppkes
On Wed, Mar 18, 2015 at 10:24 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #4375 for me. > > Please comment, Carl Eugen > Makes sense. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-d

[FFmpeg-devel] [PATCH]Do not set bitrate for DTS-HD Master and High Resolution

2015-03-18 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #4375 for me. Please comment, Carl Eugen diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c index 548a5f9..0339eef 100644 --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c @@ -1472,7 +1472,6 @@ static int dca_decode_frame(AVCodecContext *avctx, void *data,