Re: [FFmpeg-devel] [PATCH]avfilter/astreamslect: fixing activating in some cases

2018-03-18 Thread Carl Eugen Hoyos
2018-03-18 13:57 GMT+01:00, Nicolas George : > Bodecs Bela (2018-03-17): >> with my patch it works good. > > Thanks for the details. After more careful examination, I confirm my > first impression: calling ff_filter_set_ready() from the framesync > callback would be wrong. But

Re: [FFmpeg-devel] [PATCH]avfilter/astreamslect: fixing activating in some cases

2018-03-18 Thread Nicolas George
Bodecs Bela (2018-03-17): > with my patch it works good. Thanks for the details. After more careful examination, I confirm my first impression: calling ff_filter_set_ready() from the framesync callback would be wrong. But this filter already misuses internal APIs (for example re-calling

Re: [FFmpeg-devel] [PATCH]avfilter/astreamslect: fixing activating in some cases

2018-03-17 Thread Bodecs Bela
2018.03.14. 20:29 keltezéssel, Nicolas George írta: Bodecs Bela (2018-03-14): In case of some content, astreamselect filter remains in non active state. please review this pacth. I am not sure this is the right fix of this. I am not sure either. framesync was not designed for audio. I would

Re: [FFmpeg-devel] [PATCH]avfilter/astreamslect: fixing activating in some cases

2018-03-14 Thread Nicolas George
Bodecs Bela (2018-03-14): > In case of some content, astreamselect filter remains in non active > state. > > please review this pacth. I am not sure this is the right fix of this. I am not sure either. framesync was not designed for audio. I would like to investigate: can you share the failing

[FFmpeg-devel] [PATCH]avfilter/astreamslect: fixing activating in some cases

2018-03-14 Thread Bodecs Bela
Dear All, In case of some content, astreamselect filter remains in non active state. please review this pacth. I am not sure this is the right fix of this. thank you, in advance! Bela Bodecs >From acd81c80b8b5b33b03e99adb3bad04bc291e4218 Mon Sep 17 00:00:00 2001 From: Bela Bodecs