Re: [FFmpeg-devel] [PATCH]lavc/alac: Make a variable unsigned
2019-04-18 13:53 GMT+02:00, Carl Eugen Hoyos : > Attached patch silences a warning that is shown with some gcc versions. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH]lavc/alac: Make a variable unsigned
On Thu, 18 Apr 2019 15:07:03 +0200 Hendrik Leppkes wrote: > On Thu, Apr 18, 2019 at 2:54 PM Lauri Kasanen wrote: > > > > On Thu, 18 Apr 2019 13:53:37 +0200 > > Carl Eugen Hoyos wrote: > > > > > Hi! > > > > > > Attached patch silences a warning that is shown with some gcc versions. > > > > It pokes my style sense to have different things in the sizeof() and > > the var. How about uint32_t in both? > > > > Those two things are entirely unrelated types, though. Indeed, my bad. Please ignore. - Lauri ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH]lavc/alac: Make a variable unsigned
2019-04-18 14:54 GMT+02:00, Lauri Kasanen : > On Thu, 18 Apr 2019 13:53:37 +0200 > Carl Eugen Hoyos wrote: > >> Hi! >> >> Attached patch silences a warning that is shown with some gcc versions. > > It pokes my style sense to have different things in the sizeof() and > the var. How about uint32_t in both? I believe the sizeof() is an unrelated issue, I don't need 32 bit for the size, just a variable size the system likes in the 64k range. I wonder if the sizeof() isn't wrong, it looks wrong because it uses a type instead of a variable. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH]lavc/alac: Make a variable unsigned
On Thu, Apr 18, 2019 at 2:54 PM Lauri Kasanen wrote: > > On Thu, 18 Apr 2019 13:53:37 +0200 > Carl Eugen Hoyos wrote: > > > Hi! > > > > Attached patch silences a warning that is shown with some gcc versions. > > It pokes my style sense to have different things in the sizeof() and > the var. How about uint32_t in both? > Those two things are entirely unrelated types, though. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH]lavc/alac: Make a variable unsigned
On Thu, 18 Apr 2019 13:53:37 +0200 Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences a warning that is shown with some gcc versions. It pokes my style sense to have different things in the sizeof() and the var. How about uint32_t in both? - Lauri ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH]lavc/alac: Make a variable unsigned
Hi!
Attached patch silences a warning that is shown with some gcc versions.
Please comment, Carl Eugen
From 6ed77b4c191028f47f48396a782619f2ba47b716 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos
Date: Thu, 18 Apr 2019 13:51:07 +0200
Subject: [PATCH] lavc/alac: Make a variable unsigned.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Fixes a bogus compiler warning (max_samples_per_frame is checked):
libavcodec/alac.c: In function ‘allocate_buffers’:
./libavutil/internal.h:142:9: warning: argument 1 value ‘18446744073709551552’ exceeds maximum object size 9223372036854775807
---
libavcodec/alac.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/alac.c b/libavcodec/alac.c
index d6b87db..2f44340 100644
--- a/libavcodec/alac.c
+++ b/libavcodec/alac.c
@@ -486,7 +486,7 @@ static av_cold int alac_decode_close(AVCodecContext *avctx)
static int allocate_buffers(ALACContext *alac)
{
int ch;
-int buf_size = alac->max_samples_per_frame * sizeof(int32_t);
+unsigned buf_size = alac->max_samples_per_frame * sizeof(int32_t);
for (ch = 0; ch < 2; ch++) {
alac->predict_error_buffer[ch] = NULL;
--
1.7.10.4
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
