Re: [FFmpeg-devel] [PATCH]lavf/mxf: Map codec_tag for Avid files if everything else fails

2015-07-23 Thread tim nicholson
On 22/07/15 11:10, Carl Eugen Hoyos wrote: Tomas Härdin tomas.hardin at codemill.se writes: New patch attached. Looks alright. You can reindent in a separate patch if you like. Merged by Michael with the reindentation. There is still a cropping issue for the given sample: Am I

Re: [FFmpeg-devel] [PATCH]lavf/mxf: Map codec_tag for Avid files if everything else fails

2015-07-22 Thread Carl Eugen Hoyos
Tomas Härdin tomas.hardin at codemill.se writes: New patch attached. Looks alright. You can reindent in a separate patch if you like. Merged by Michael with the reindentation. There is still a cropping issue for the given sample: Am I correct that the generic descriptors 0x3208 and

Re: [FFmpeg-devel] [PATCH]lavf/mxf: Map codec_tag for Avid files if everything else fails

2015-07-21 Thread Tomas Härdin
On Fri, 2015-07-17 at 12:36 +0200, Carl Eugen Hoyos wrote: On Saturday 11 July 2015 04:13:52 pm Tomas Härdin wrote: Just a quick review since I have to bounce: +const MXFCodecUL ff_mxf_codec_tag_uls[] = { Haven't we moved this to mxf.c already? Or rather, don't we have a whole bunch

Re: [FFmpeg-devel] [PATCH]lavf/mxf: Map codec_tag for Avid files if everything else fails

2015-07-17 Thread Carl Eugen Hoyos
On Saturday 11 July 2015 04:13:52 pm Tomas Härdin wrote: Just a quick review since I have to bounce: +const MXFCodecUL ff_mxf_codec_tag_uls[] = { Haven't we moved this to mxf.c already? Or rather, don't we have a whole bunch of very similar tables already? The new table is (together with

Re: [FFmpeg-devel] [PATCH]lavf/mxf: Map codec_tag for Avid files if everything else fails

2015-07-11 Thread Tomas Härdin
On Fri, 2015-07-10 at 20:11 +0200, Carl Eugen Hoyos wrote: Hi! Attached patch allows decoding of the sample provided on ffmpeg-user: http://ffmpeg.org/pipermail/ffmpeg-user/2015-July/027472.html Better suggestions welcome, Carl Eugen Just a quick review since I have to bounce: +const

[FFmpeg-devel] [PATCH]lavf/mxf: Map codec_tag for Avid files if everything else fails

2015-07-10 Thread Carl Eugen Hoyos
Hi! Attached patch allows decoding of the sample provided on ffmpeg-user: http://ffmpeg.org/pipermail/ffmpeg-user/2015-July/027472.html Better suggestions welcome, Carl Eugen diff --git a/libavformat/mxf.c b/libavformat/mxf.c index ecfb8a2..dc712bb 100644 --- a/libavformat/mxf.c +++