Re: [FFmpeg-devel] [PATCH 05/10] avformat/matroskadec: Remove non-incremental parsing of clusters

Michael Niedermayer: > > thanks for the detailed analysis, and yes i agree this is a bug in > existing code > Does this mean that the fact that this patch affects seeking does not hinder its merging? Or does the seeking issue have to be fixed first? In the latter case, I'd omitt this patch for n

Re: [FFmpeg-devel] [PATCH 05/10] avformat/matroskadec: Remove non-incremental parsing of clusters

On Tue, Mar 12, 2019 at 05:05:00AM +, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Sun, Mar 10, 2019 at 11:03:00PM +, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> On Fri, Mar 08, 2019 at 10:25:59AM +0100, Andreas Rheinhardt wrote: > When the new incremental pars

Re: [FFmpeg-devel] [PATCH 05/10] avformat/matroskadec: Remove non-incremental parsing of clusters

Michael Niedermayer: > On Sun, Mar 10, 2019 at 11:03:00PM +, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> On Fri, Mar 08, 2019 at 10:25:59AM +0100, Andreas Rheinhardt wrote: When the new incremental parser was introduced, the old parser was kept, because the new parser was un

Re: [FFmpeg-devel] [PATCH 05/10] avformat/matroskadec: Remove non-incremental parsing of clusters

On Sun, Mar 10, 2019 at 11:03:00PM +, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Fri, Mar 08, 2019 at 10:25:59AM +0100, Andreas Rheinhardt wrote: > >> When the new incremental parser was introduced, the old parser was > >> kept, because the new parser was unable to handle the way S

Re: [FFmpeg-devel] [PATCH 05/10] avformat/matroskadec: Remove non-incremental parsing of clusters

Michael Niedermayer: > On Fri, Mar 08, 2019 at 10:25:59AM +0100, Andreas Rheinhardt wrote: >> When the new incremental parser was introduced, the old parser was >> kept, because the new parser was unable to handle the way SSA packets >> are put into Matroska. But since 2014 (since >> c7d8dbad14ed5f

Re: [FFmpeg-devel] [PATCH 05/10] avformat/matroskadec: Remove non-incremental parsing of clusters

On Fri, Mar 08, 2019 at 10:25:59AM +0100, Andreas Rheinhardt wrote: > When the new incremental parser was introduced, the old parser was > kept, because the new parser was unable to handle the way SSA packets > are put into Matroska. But since 2014 (since > c7d8dbad14ed5fa3c217a4fc1790021d6c0b6416)

[FFmpeg-devel] [PATCH 05/10] avformat/matroskadec: Remove non-incremental parsing of clusters

When the new incremental parser was introduced, the old parser was kept, because the new parser was unable to handle the way SSA packets are put into Matroska. But since 2014 (since c7d8dbad14ed5fa3c217a4fc1790021d6c0b6416) this is no longer needed, so that the old parser can be completely removed.