Re: [FFmpeg-devel] [PATCH 05/20] avformat/matroskaenc: Check return value of ff_isom_write_hvcc()

2020-01-01 Thread Michael Niedermayer
On Wed, Jan 01, 2020 at 12:42:51PM +0800, myp...@gmail.com wrote: > On Wed, Jan 1, 2020 at 8:59 AM Andreas Rheinhardt > wrote: > > > > The Matroska muxer currently does not check the return value of > > ff_isom_write_hvcc(), the function used to write mp4-style > > HEVC-extradata as Matroska also

Re: [FFmpeg-devel] [PATCH 05/20] avformat/matroskaenc: Check return value of ff_isom_write_hvcc()

2019-12-31 Thread myp...@gmail.com
On Wed, Jan 1, 2020 at 8:59 AM Andreas Rheinhardt wrote: > > The Matroska muxer currently does not check the return value of > ff_isom_write_hvcc(), the function used to write mp4-style > HEVC-extradata as Matroska also uses it. This was intentionally done in > 7a5356c72 to allow remuxing from

[FFmpeg-devel] [PATCH 05/20] avformat/matroskaenc: Check return value of ff_isom_write_hvcc()

2019-12-31 Thread Andreas Rheinhardt
The Matroska muxer currently does not check the return value of ff_isom_write_hvcc(), the function used to write mp4-style HEVC-extradata as Matroska also uses it. This was intentionally done in 7a5356c72 to allow remuxing from mpeg-ts. But if ff_isom_write_hvcc() fails, it has not output