Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 6:16 PM, Henrik Gramner wrote: > On Tue, Oct 13, 2015 at 11:58 PM, Ganesh Ajjanagadde wrote: >> On Tue, Oct 13, 2015 at 5:55 PM, Henrik Gramner wrote: >>> On Tue, Oct 13, 2015 at 11:28 PM, Ganesh Ajjanagadde >>> wrote: Not really that important, but unless this inc

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Henrik Gramner
On Tue, Oct 13, 2015 at 11:58 PM, Ganesh Ajjanagadde wrote: > On Tue, Oct 13, 2015 at 5:55 PM, Henrik Gramner wrote: >> On Tue, Oct 13, 2015 at 11:28 PM, Ganesh Ajjanagadde >> wrote: >>> Not really that important, but unless this increases FATE time >>> significantly, I would recommend a much l

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 5:55 PM, Henrik Gramner wrote: > On Tue, Oct 13, 2015 at 11:28 PM, Ganesh Ajjanagadde wrote: >> Not really that important, but unless this increases FATE time >> significantly, I would recommend a much larger MAX_COUNT, and multiple >> iterations (e.g #define an ITER_COUNT

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Henrik Gramner
On Tue, Oct 13, 2015 at 11:28 PM, Ganesh Ajjanagadde wrote: > Not really that important, but unless this increases FATE time > significantly, I would recommend a much larger MAX_COUNT, and multiple > iterations (e.g #define an ITER_COUNT), so that the testing is more > extensive over random inputs

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 5:06 PM, Henrik Gramner wrote: > Added some randomization to count and made report() less verbose: > > diff --git a/tests/checkasm/aes.c b/tests/checkasm/aes.c > index 67b..4549a3d 100644 > --- a/tests/checkasm/aes.c > +++ b/tests/checkasm/aes.c > @@ -23,12 +23,14 @@ >

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Henrik Gramner
Added some randomization to count and made report() less verbose: diff --git a/tests/checkasm/aes.c b/tests/checkasm/aes.c index 67b..4549a3d 100644 --- a/tests/checkasm/aes.c +++ b/tests/checkasm/aes.c @@ -23,12 +23,14 @@ #include "libavutil/aes_internal.h" #include "libavutil/internal.h"

[FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-12 Thread Rodger Combs
--- tests/checkasm/Makefile | 2 +- tests/checkasm/aes.c | 57 +++ tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + 4 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 tests/checkasm/aes.c diff --git a/tests/c