Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Michael Niedermayer
On Mon, Nov 23, 2015 at 01:57:24PM -0500, Ganesh Ajjanagadde wrote: > On Mon, Nov 23, 2015 at 1:02 PM, Michael Niedermayer wrote: > > On Mon, Nov 23, 2015 at 12:43:52PM -0500, Ganesh Ajjanagadde wrote: > >> On Sun, Nov 22, 2015 at 3:56 PM, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Michael Niedermayer
On Mon, Nov 23, 2015 at 12:43:52PM -0500, Ganesh Ajjanagadde wrote: > On Sun, Nov 22, 2015 at 3:56 PM, Ganesh Ajjanagadde wrote: > > On Sun, Nov 22, 2015 at 3:07 PM, Michael Niedermayer > > wrote: > >> On Sun, Nov 22, 2015 at 12:05:49PM -0500, Ganesh

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Nicolas George
Le tridi 3 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > I do recall that, but mandelbrot has issues with such benchmarks due > to variable number of iterations as I observed while playing with it > and as pointed out by Michael. It was hence that I proposed the inner > loop benchmark which

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Ganesh Ajjanagadde
On Mon, Nov 23, 2015 at 1:15 PM, Nicolas George wrote: > Le tridi 3 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> I do recall that, but mandelbrot has issues with such benchmarks due >> to variable number of iterations as I observed while playing with it >> and as pointed

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Ganesh Ajjanagadde
On Mon, Nov 23, 2015 at 12:54 PM, Nicolas George wrote: > Le tridi 3 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> It seems like getting rid of the sqrt altogether has a very slight >> positive impact (if any at all). I can post the patch, but would like >> to know what to

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Michael Niedermayer
On Mon, Nov 23, 2015 at 03:48:40PM -0500, Ganesh Ajjanagadde wrote: > On Mon, Nov 23, 2015 at 2:13 PM, Michael Niedermayer wrote: > > On Mon, Nov 23, 2015 at 01:57:24PM -0500, Ganesh Ajjanagadde wrote: > >> On Mon, Nov 23, 2015 at 1:02 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Ganesh Ajjanagadde
On Mon, Nov 23, 2015 at 1:02 PM, Michael Niedermayer wrote: > On Mon, Nov 23, 2015 at 12:43:52PM -0500, Ganesh Ajjanagadde wrote: >> On Sun, Nov 22, 2015 at 3:56 PM, Ganesh Ajjanagadde wrote: >> > On Sun, Nov 22, 2015 at 3:07 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Ganesh Ajjanagadde
On Sun, Nov 22, 2015 at 3:56 PM, Ganesh Ajjanagadde wrote: > On Sun, Nov 22, 2015 at 3:07 PM, Michael Niedermayer wrote: >> On Sun, Nov 22, 2015 at 12:05:49PM -0500, Ganesh Ajjanagadde wrote: >>> Signed-off-by: Ganesh Ajjanagadde >>>

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Nicolas George
Le tridi 3 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > It seems like getting rid of the sqrt altogether has a very slight > positive impact (if any at all). I can post the patch, but would like > to know what to benchmark. There are numerous choices, e.g > draw_mandelbrot as a whole, the

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Ganesh Ajjanagadde
On Mon, Nov 23, 2015 at 2:13 PM, Michael Niedermayer wrote: > On Mon, Nov 23, 2015 at 01:57:24PM -0500, Ganesh Ajjanagadde wrote: >> On Mon, Nov 23, 2015 at 1:02 PM, Michael Niedermayer >> wrote: >> > On Mon, Nov 23, 2015 at 12:43:52PM -0500, Ganesh

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-23 Thread Michael Niedermayer
On Mon, Nov 23, 2015 at 03:48:40PM -0500, Ganesh Ajjanagadde wrote: > On Mon, Nov 23, 2015 at 2:13 PM, Michael Niedermayer wrote: > > On Mon, Nov 23, 2015 at 01:57:24PM -0500, Ganesh Ajjanagadde wrote: > >> On Mon, Nov 23, 2015 at 1:02 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-22 Thread Michael Niedermayer
On Sun, Nov 22, 2015 at 12:05:49PM -0500, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/vsrc_mandelbrot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vsrc_mandelbrot.c

[FFmpeg-devel] [PATCH 09/10] avfilter/vsrc_mandelbrot: use hypot()

2015-11-22 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vsrc_mandelbrot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vsrc_mandelbrot.c b/libavfilter/vsrc_mandelbrot.c index 950c5c8..a0c101e 100644 --- a/libavfilter/vsrc_mandelbrot.c +++