Re: [FFmpeg-devel] [PATCH 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-22 Thread Paul B Mahol
On Sat, Jul 22, 2023 at 5:25 PM Nicolas George wrote: > Paul B Mahol (12023-07-22): > > What about an audio? > > Are we in the business of refusing a patch adding an interesting feature > because we want two interesting features instead? > Double standards, not unexpected from you. > > > This

Re: [FFmpeg-devel] [PATCH 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-22 Thread John Cox
On Sat, 22 Jul 2023 17:28:31 +0200, you wrote: >On Thu, Jul 20, 2023 at 1:40?PM John Cox wrote: > >> Add a callback to enable user allocation of video frames on the final >> stage of a filter chain. >> >> >What about an audio? I have a use case for video and none for audio, but I can add audio

Re: [FFmpeg-devel] [PATCH 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-22 Thread John Cox
Hi On Sat, 22 Jul 2023 17:12:51 +0200, you wrote: >John Cox (12023-07-20): >> Add a callback to enable user allocation of video frames on the final >> stage of a filter chain. >> >> Signed-off-by: John Cox >> --- >> libavfilter/buffersink.c | 21 + >>

Re: [FFmpeg-devel] [PATCH 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-22 Thread Nicolas George
Paul B Mahol (12023-07-22): > What about an audio? Are we in the business of refusing a patch adding an interesting feature because we want two interesting features instead? > This works only for sinks mostly, what about filters inside graph? It is already in place, it has been for years. This

Re: [FFmpeg-devel] [PATCH 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-22 Thread Paul B Mahol
On Thu, Jul 20, 2023 at 1:40 PM John Cox wrote: > Add a callback to enable user allocation of video frames on the final > stage of a filter chain. > > What about an audio? This works only for sinks mostly, what about filters inside graph? > Signed-off-by: John Cox > --- >

Re: [FFmpeg-devel] [PATCH 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-22 Thread Nicolas George
John Cox (12023-07-20): > Add a callback to enable user allocation of video frames on the final > stage of a filter chain. > > Signed-off-by: John Cox > --- > libavfilter/buffersink.c | 21 + > libavfilter/buffersink.h | 27 +++ >

[FFmpeg-devel] [PATCH 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-20 Thread John Cox
Add a callback to enable user allocation of video frames on the final stage of a filter chain. Signed-off-by: John Cox --- libavfilter/buffersink.c | 21 + libavfilter/buffersink.h | 27 +++ libavfilter/version.h| 2 +- 3 files changed, 49