Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-15 Thread Michael Niedermayer
On Tue, May 14, 2019 at 10:31:00PM +0200, Marton Balint wrote: > > > On Wed, 8 May 2019, Michael Niedermayer wrote: > > >On Tue, May 07, 2019 at 02:03:22AM +0200, Marton Balint wrote: > >> > >> > >>On Tue, 7 May 2019, Michael Niedermayer wrote: > >> > >>>On Sun, May 05, 2019 at 08:51:08PM

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-14 Thread Marton Balint
On Wed, 8 May 2019, Michael Niedermayer wrote: On Tue, May 07, 2019 at 02:03:22AM +0200, Marton Balint wrote: On Tue, 7 May 2019, Michael Niedermayer wrote: On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. I

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-08 Thread Kieran Kunhya
> > if you dont return 3 fields you break the normative specification. This > speaks > about the "output of the decoding process" not how to interpret the output. > > I bring MPEG2 up here because we dont do what the normative spec says > because it doesnt make sense for us. It does make sense if

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-08 Thread Michael Niedermayer
On Tue, May 07, 2019 at 01:39:44AM +0200, Hendrik Leppkes wrote: > On Tue, May 7, 2019 at 12:34 AM Michael Niedermayer > wrote: > > > > On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: > > > This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. > > > > > > I don't think it

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-07 Thread Michael Niedermayer
On Tue, May 07, 2019 at 02:03:22AM +0200, Marton Balint wrote: > > > On Tue, 7 May 2019, Michael Niedermayer wrote: > > >On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: > >>This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. > >> > >>I don't think it is a good idea to

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-06 Thread Marton Balint
On Tue, 7 May 2019, Michael Niedermayer wrote: On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. I don't think it is a good idea to drop frames from CFR input just because they are duplicated, that can cause issues

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-06 Thread Hendrik Leppkes
On Tue, May 7, 2019 at 1:39 AM Hendrik Leppkes wrote: > > On Tue, May 7, 2019 at 12:34 AM Michael Niedermayer > wrote: > > > > On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: > > > This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. > > > > > > I don't think it is a good

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-06 Thread Hendrik Leppkes
On Tue, May 7, 2019 at 12:34 AM Michael Niedermayer wrote: > > On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: > > This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. > > > > I don't think it is a good idea to drop frames from CFR input just because > > they > > are

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-06 Thread Michael Niedermayer
On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: > This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. > > I don't think it is a good idea to drop frames from CFR input just because > they > are duplicated, that can cause issues for API users expecting CFR input. Also >

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-05 Thread Hendrik Leppkes
On Sun, May 5, 2019 at 8:51 PM Marton Balint wrote: > > This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. > > I don't think it is a good idea to drop frames from CFR input just because > they > are duplicated, that can cause issues for API users expecting CFR input. Also > it can

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-05 Thread Carl Eugen Hoyos
Am So., 5. Mai 2019 um 20:51 Uhr schrieb Marton Balint : > > This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. > > I don't think it is a good idea to drop frames from CFR input just because > they > are duplicated, that can cause issues for API users expecting CFR input. Also > it can

[FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-05 Thread Marton Balint
This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. I don't think it is a good idea to drop frames from CFR input just because they are duplicated, that can cause issues for API users expecting CFR input. Also it can cause issues at the end of file, if the last frame is a duplicated