Re: [FFmpeg-devel] [PATCH 1/2] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-16 Thread Steven Liu
Carl Eugen Hoyos 于2018年12月17日周一 上午8:29写道: > > 2018-12-16 14:19 GMT+01:00, Steven Liu : > > move the two if condition out of the loop, that can less > > n-1 times than condition in loop. > > Please add some benchmarks to the commit message. Hi Folks, I tested the performance of the modify, before

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-16 Thread Carl Eugen Hoyos
2018-12-16 14:19 GMT+01:00, Steven Liu : > move the two if condition out of the loop, that can less > n-1 times than condition in loop. Please add some benchmarks to the commit message. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-16 Thread Steven Liu
> On Dec 16, 2018, at 21:47, Moritz Barsnick wrote: > > On Sun, Dec 16, 2018 at 21:19:17 +0800, Steven Liu wrote: >> move the two if condition out of the loop, that can less n-1 times than >> condition >> in loop. > [...] >> k = -split_radix_permutation(i, n, s->inverse) & (n-1); >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-16 Thread Moritz Barsnick
On Sun, Dec 16, 2018 at 21:19:17 +0800, Steven Liu wrote: > move the two if condition out of the loop, that can less n-1 times than > condition > in loop. [...] > k = -split_radix_permutation(i, n, s->inverse) & (n-1); > -if (s->revtab) > s->revtab[k] = j;

[FFmpeg-devel] [PATCH 1/2] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-16 Thread Steven Liu
move the two if condition out of the loop, that can less n-1 times than condition in loop. Signed-off-by: Steven Liu --- libavcodec/fft_template.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavcodec/fft_template.c b/libavcodec/fft_template.c index 762