Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: Added an option to disable SIDX atom

2018-12-04 Thread Jeyapal, Karthick
On 12/4/18, 2:18 PM, "Gyan Doshi" wrote: >On 04-12-2018 02:11 PM, Karthick J wrote: > >> [...] >> +@item -movflags no_sidx >> +Don't write sidx atom. > >Append a short note advising when this is required or recommended and >when not. Thanks for your comment. I have added more details in PATCH v2

Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: Added an option to disable SIDX atom

2018-12-04 Thread Jeyapal, Karthick
On 12/4/18, 4:25 PM, "Tobias Rapp" wrote: >>On 04.12.2018 09:41, Karthick J wrote: >>[...] >> Run a second pass moving the index (moov atom) to the beginning of the >> file. >> This operation can take a while, and will not work in various situations >> such > >What about naming the option

Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: Added an option to disable SIDX atom

2018-12-04 Thread Tobias Rapp
On 04.12.2018 09:41, Karthick J wrote: --- doc/muxers.texi | 2 ++ libavformat/movenc.c | 7 +-- libavformat/movenc.h | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index f1cc6f5fee..6ca27b04a3 100644 --- a/doc/muxers.texi +++

Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: Added an option to disable SIDX atom

2018-12-04 Thread Gyan Doshi
On 04-12-2018 02:11 PM, Karthick J wrote: diff --git a/doc/muxers.texi b/doc/muxers.texi index f1cc6f5fee..6ca27b04a3 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1325,6 +1325,8 @@ more efficient), but with this option set, the muxer writes one moof/mdat pair for each track, making

[FFmpeg-devel] [PATCH 1/2] avformat/movenc: Added an option to disable SIDX atom

2018-12-04 Thread Karthick J
--- doc/muxers.texi | 2 ++ libavformat/movenc.c | 7 +-- libavformat/movenc.h | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index f1cc6f5fee..6ca27b04a3 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1325,6 +1325,8 @@ more