Re: [FFmpeg-devel] [PATCH 1/2] avformat: read id3v2 comment tags

2016-07-23 Thread Michael Niedermayer
On Fri, Jul 22, 2016 at 05:59:09PM -0700, kod...@gmail.com wrote: > From: Chris Moeller > > --- > libavformat/id3v2.c | 44 > 1 file changed, 44 insertions(+) > > diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c > index

Re: [FFmpeg-devel] [PATCH 1/2] avformat: read id3v2 comment tags

2016-07-22 Thread Josh de Kock
On Sat, Jul 23, 2016, at 01:59 AM, kod...@gmail.com wrote: > [...] > > /** > + * Parse a comment tag. > + */ > +static void read_comm(AVFormatContext *s, AVIOContext *pb, int taglen, > + AVDictionary **metadata) This should probably be `read_comment`, it's not too long of a

[FFmpeg-devel] [PATCH 1/2] avformat: read id3v2 comment tags

2016-07-22 Thread kode54
From: Chris Moeller --- libavformat/id3v2.c | 44 1 file changed, 44 insertions(+) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index 46b9394..c38c610 100644 --- a/libavformat/id3v2.c +++ b/libavformat/id3v2.c @@ -400,6

Re: [FFmpeg-devel] [PATCH 1/2] avformat: read id3v2 comment tags

2016-07-22 Thread Christopher Snowhill
Sorry for the noise, I made some poor assumptions. First, I wasn’t really paying attention when it mentioned the whitespace errors on apply, and didn’t correct them the first time. Second, I didn’t realize that it would ignore my —subject directive when sending the revised first patch. Now I

[FFmpeg-devel] [PATCH 1/2] avformat: read id3v2 comment tags

2016-07-22 Thread kode54
From: Chris Moeller --- libavformat/id3v2.c | 44 1 file changed, 44 insertions(+) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index 46b9394..c38c610 100644 --- a/libavformat/id3v2.c +++ b/libavformat/id3v2.c @@ -400,6