Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

2019-04-02 Thread Carl Eugen Hoyos
2019-04-02 22:16 GMT+02:00, Matthew Fearnley : > By the way, is there a recommended way to enable #ifdef blocks > when building ffmpeg? --extra-cflags come to mind. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

2019-04-02 Thread Matthew Fearnley
> On 2 Apr 2019, at 16:48, Tomas Härdin wrote: > > mån 2019-04-01 klockan 13:29 +0100 skrev Matthew Fearnley: > On 1 Apr 2019, at 10:28, Tomas Härdin wrote: >>> >>> fre 2019-03-29 klockan 22:23 + skrev Matthew Fearnley: >> On Wed, 27 Mar 2019 at 09:42, Tomas Härdin wrote: >>

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

2019-04-02 Thread Tomas Härdin
mån 2019-04-01 klockan 13:29 +0100 skrev Matthew Fearnley: > > > > On 1 Apr 2019, at 10:28, Tomas Härdin wrote: > > > > fre 2019-03-29 klockan 22:23 + skrev Matthew Fearnley: > > > > > On Wed, 27 Mar 2019 at 09:42, Tomas Härdin wrote: > > > > > Additional minor fix: use PTRDIFF_SPECIFIER

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

2019-04-01 Thread Tomas Härdin
mån 2019-04-01 klockan 13:29 +0100 skrev Matthew Fearnley: > > On 1 Apr 2019, at 10:28, Tomas Härdin wrote: > > > > fre 2019-03-29 klockan 22:23 + skrev Matthew Fearnley: > > > > > On Wed, 27 Mar 2019 at 09:42, Tomas Härdin > > > > e> wrote: > > > > > Additional minor fix: use

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

2019-04-01 Thread Matthew Fearnley
> On 1 Apr 2019, at 10:28, Tomas Härdin wrote: > > fre 2019-03-29 klockan 22:23 + skrev Matthew Fearnley: On Wed, 27 Mar 2019 at 09:42, Tomas Härdin wrote: Additional minor fix: use PTRDIFF_SPECIFIER for `src - c->decomp_buf`. Other bit depths saw this change in ced0d6c14d,

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

2019-04-01 Thread Tomas Härdin
fre 2019-03-29 klockan 22:23 + skrev Matthew Fearnley: > > On Wed, 27 Mar 2019 at 09:42, Tomas Härdin wrote: > > > Additional minor fix: use PTRDIFF_SPECIFIER for `src - c->decomp_buf`. > > > Other bit depths saw this change in ced0d6c14d, but this instance was > > > missed, presumably

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

2019-03-29 Thread Matthew Fearnley
On Wed, 27 Mar 2019 at 09:42, Tomas Härdin wrote: > tis 2019-03-26 klockan 22:13 + skrev Matthew Fearnley: > > This brings the channel order in line with that used in 32-bit mode > (BGR0). > > > > 24-bit decoding is disabled by default (#ifdef ZMBV_ENABLE_24BPP), and no > > prior encoders or

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

2019-03-27 Thread Tomas Härdin
tis 2019-03-26 klockan 22:13 + skrev Matthew Fearnley: > This brings the channel order in line with that used in 32-bit mode (BGR0). > > 24-bit decoding is disabled by default (#ifdef ZMBV_ENABLE_24BPP), and no > prior encoders or sample videos are known to exist for this bit depth, so > I

[FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

2019-03-26 Thread Matthew Fearnley
This brings the channel order in line with that used in 32-bit mode (BGR0). 24-bit decoding is disabled by default (#ifdef ZMBV_ENABLE_24BPP), and no prior encoders or sample videos are known to exist for this bit depth, so I consider this change in implementation is unlikely to affect anyone.