Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-22 Thread Michael Niedermayer
On Fri, Feb 22, 2019 at 01:09:12PM +0100, Tomas Härdin wrote: > fre 2019-02-22 klockan 00:11 +0100 skrev Michael Niedermayer: > > On Thu, Feb 21, 2019 at 09:26:44PM +, Matthew Fearnley wrote: > > > - To clear up the effects: the change from 'i=1' to 'i=0' was the only > > > change that should

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-22 Thread Tomas Härdin
fre 2019-02-22 klockan 13:09 +0100 skrev Tomas Härdin: > fre 2019-02-22 klockan 00:11 +0100 skrev Michael Niedermayer: > > On Thu, Feb 21, 2019 at 09:26:44PM +, Matthew Fearnley wrote: > > > - To clear up the effects: the change from 'i=1' to 'i=0' was the only > > > change that should make

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-22 Thread Tomas Härdin
fre 2019-02-22 klockan 00:11 +0100 skrev Michael Niedermayer: > On Thu, Feb 21, 2019 at 09:26:44PM +, Matthew Fearnley wrote: > > - To clear up the effects: the change from 'i=1' to 'i=0' was the only > > change that should make any difference in the output. > > The rest of the changes were to

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-22 Thread Tomas Härdin
tor 2019-02-21 klockan 15:26 +0100 skrev Carl Eugen Hoyos: > > 2019-02-21 11:26 GMT+01:00, Tomas Härdin : > > ons 2019-02-20 klockan 23:33 +0100 skrev Carl Eugen Hoyos: > > > > > > > > 2019-02-10 16:42 GMT+01:00, Tomas Härdin : > > > > lör 2019-02-09 klockan 13:10 + skrev Matthew Fearnley: > >

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-21 Thread Michael Niedermayer
On Thu, Feb 21, 2019 at 09:26:44PM +, Matthew Fearnley wrote: > On Thu, 21 Feb 2019 at 19:28, Michael Niedermayer > wrote: > > > On Thu, Feb 21, 2019 at 11:19:08AM +0100, Tomas Härdin wrote: > > > ons 2019-02-20 klockan 22:12 +0100 skrev Michael Niedermayer: > > > > On Sat, Feb 09, 2019 at

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-21 Thread Matthew Fearnley
On Thu, 21 Feb 2019 at 19:28, Michael Niedermayer wrote: > On Thu, Feb 21, 2019 at 11:19:08AM +0100, Tomas Härdin wrote: > > ons 2019-02-20 klockan 22:12 +0100 skrev Michael Niedermayer: > > > On Sat, Feb 09, 2019 at 01:10:20PM +, Matthew Fearnley wrote: > > > > - Improve block choices by

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-21 Thread Michael Niedermayer
On Thu, Feb 21, 2019 at 11:19:08AM +0100, Tomas Härdin wrote: > ons 2019-02-20 klockan 22:12 +0100 skrev Michael Niedermayer: > > On Sat, Feb 09, 2019 at 01:10:20PM +, Matthew Fearnley wrote: > > > - Improve block choices by counting 0-bytes in the entropy score > > > - Make histogram use

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-21 Thread Carl Eugen Hoyos
2019-02-21 15:08 GMT+01:00, Matthew Fearnley : > The question would still remain though, of the best way to incorporate it > into FFMEG. That's probably beyond my current knowledge.. It belongs in libavutil, see also the unfinished inflate implementation:

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-21 Thread Carl Eugen Hoyos
2019-02-21 11:26 GMT+01:00, Tomas Härdin : > ons 2019-02-20 klockan 23:33 +0100 skrev Carl Eugen Hoyos: >> > 2019-02-10 16:42 GMT+01:00, Tomas Härdin : >> > lör 2019-02-09 klockan 13:10 + skrev Matthew Fearnley: >> > > - Improve block choices by counting 0-bytes in the entropy score >> > > -

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-21 Thread Matthew Fearnley
On Thu, 21 Feb 2019 at 10:26, Tomas Härdin wrote: > ons 2019-02-20 klockan 23:33 +0100 skrev Carl Eugen Hoyos: > > > 2019-02-10 16:42 GMT+01:00, Tomas Härdin : > > > lör 2019-02-09 klockan 13:10 + skrev Matthew Fearnley: > > > > - Improve block choices by counting 0-bytes in the entropy

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-21 Thread Tomas Härdin
tor 2019-02-21 klockan 11:26 +0100 skrev Tomas Härdin: > ons 2019-02-20 klockan 23:33 +0100 skrev Carl Eugen Hoyos: > > > > > > 2019-02-10 16:42 GMT+01:00, Tomas Härdin : > > > lör 2019-02-09 klockan 13:10 + skrev Matthew Fearnley: > > > > - Improve block choices by counting 0-bytes in the

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-21 Thread Tomas Härdin
ons 2019-02-20 klockan 23:33 +0100 skrev Carl Eugen Hoyos: > > 2019-02-10 16:42 GMT+01:00, Tomas Härdin : > > lör 2019-02-09 klockan 13:10 + skrev Matthew Fearnley: > > > - Improve block choices by counting 0-bytes in the entropy score > > > - Make histogram use uint16_t type, to allow byte

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-21 Thread Tomas Härdin
ons 2019-02-20 klockan 22:12 +0100 skrev Michael Niedermayer: > On Sat, Feb 09, 2019 at 01:10:20PM +, Matthew Fearnley wrote: > > - Improve block choices by counting 0-bytes in the entropy score > > - Make histogram use uint16_t type, to allow byte counts from 16*16 > > (current block size) up

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-20 Thread Carl Eugen Hoyos
2019-02-10 16:42 GMT+01:00, Tomas Härdin : > lör 2019-02-09 klockan 13:10 + skrev Matthew Fearnley: >> - Improve block choices by counting 0-bytes in the entropy score >> - Make histogram use uint16_t type, to allow byte counts from 16*16 >> (current block size) up to 255*255 (maximum allowed

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-20 Thread Michael Niedermayer
On Sat, Feb 09, 2019 at 01:10:20PM +, Matthew Fearnley wrote: > - Improve block choices by counting 0-bytes in the entropy score > - Make histogram use uint16_t type, to allow byte counts from 16*16 > (current block size) up to 255*255 (maximum allowed 8bpp block size) > - Make sure score

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-10 Thread Tomas Härdin
lör 2019-02-09 klockan 13:10 + skrev Matthew Fearnley: > - Improve block choices by counting 0-bytes in the entropy score > - Make histogram use uint16_t type, to allow byte counts from 16*16 > (current block size) up to 255*255 (maximum allowed 8bpp block size) > - Make sure score table is

[FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-09 Thread Matthew Fearnley
- Improve block choices by counting 0-bytes in the entropy score - Make histogram use uint16_t type, to allow byte counts from 16*16 (current block size) up to 255*255 (maximum allowed 8bpp block size) - Make sure score table is big enough for a full block's worth of bytes - Calculate *xored