Re: [FFmpeg-devel] [PATCH 1/2] libavutil: Undeprecate the AVFrame reordered_opaque field

2018-10-29 Thread Derek Buitenhuis
On 29/10/2018 20:10, Martin Storsjö wrote: > Sorry, I think you've misunderstood this patch altogether. > > It's not about reviving this field or not, it's all in full use > already. It was never deprecated with any active plan to remove it, the > only steps were a few doxygen comments, never any

Re: [FFmpeg-devel] [PATCH 1/2] libavutil: Undeprecate the AVFrame reordered_opaque field

2018-10-29 Thread Martin Storsjö
On Mon, 29 Oct 2018, Derek Buitenhuis wrote: On 29/10/2018 14:10, Martin Storsjö wrote: I don't understand why this is being used in favour of a proper pointer field? An integer field is just ascting to be misused. Even the doxygen is really sketchy on it. It's essentially meant to be used as

Re: [FFmpeg-devel] [PATCH 1/2] libavutil: Undeprecate the AVFrame reordered_opaque field

2018-10-29 Thread Derek Buitenhuis
On 29/10/2018 14:10, Martin Storsjö wrote: >> I don't understand why this is being used in favour of a proper >> pointer field? An integer field is just ascting to be misused. >> Even the doxygen is really sketchy on it. > > It's essentially meant to be used as union { ptr; int64_t } assuming you

Re: [FFmpeg-devel] [PATCH 1/2] libavutil: Undeprecate the AVFrame reordered_opaque field

2018-10-29 Thread Martin Storsjö
On Mon, 29 Oct 2018, Derek Buitenhuis wrote: On 25/10/2018 13:58, Martin Storsjö wrote: This was marked as deprecated (but only in the doxygen, not with an actual deprecation attribute) in 81c623fae05 in 2011, but was undeprecated in ad1ee5fa7. --- libavutil/frame.h | 1 - libavutil/versio

Re: [FFmpeg-devel] [PATCH 1/2] libavutil: Undeprecate the AVFrame reordered_opaque field

2018-10-29 Thread Derek Buitenhuis
On 25/10/2018 13:58, Martin Storsjö wrote: > This was marked as deprecated (but only in the doxygen, not with an > actual deprecation attribute) in 81c623fae05 in 2011, but was > undeprecated in ad1ee5fa7. > --- > libavutil/frame.h | 1 - > libavutil/version.h | 2 +- > 2 files changed, 1 ins

[FFmpeg-devel] [PATCH 1/2] libavutil: Undeprecate the AVFrame reordered_opaque field

2018-10-25 Thread Martin Storsjö
This was marked as deprecated (but only in the doxygen, not with an actual deprecation attribute) in 81c623fae05 in 2011, but was undeprecated in ad1ee5fa7. --- libavutil/frame.h | 1 - libavutil/version.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libavutil/frame.h b/