Re: [FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

2019-10-19 Thread Michael Niedermayer
On Fri, Oct 18, 2019 at 04:44:00AM +, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Wed, Oct 16, 2019 at 12:43:07PM +0200, Paul B Mahol wrote: > >> Could someone apply this? > > > > will apply > > > > thx > > > > [...] > > > Thanks. There is also a follow-up patch [1] to this

Re: [FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

2019-10-17 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Oct 16, 2019 at 12:43:07PM +0200, Paul B Mahol wrote: >> Could someone apply this? > > will apply > > thx > > [...] > Thanks. There is also a follow-up patch [1] to this that you have already LGTM'ed in July. Can you apply it, too, please? - Andreas [1]:

Re: [FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

2019-10-17 Thread Michael Niedermayer
On Wed, Oct 16, 2019 at 12:43:07PM +0200, Paul B Mahol wrote: > Could someone apply this? will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matters, not just one of them. signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

2019-10-16 Thread Paul B Mahol
Could someone apply this? On 10/16/19, Andreas Rheinhardt wrote: > Andreas Rheinhardt: >> Andreas Rheinhardt: >>> Andreas Rheinhardt: 1. Since bd90a2ec, mpeg4_unpack_bframes caches whole packets instead of just the pointer to the buffer and the buffer's size in order to be able to

Re: [FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

2019-10-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> Andreas Rheinhardt: >>> 1. Since bd90a2ec, mpeg4_unpack_bframes caches whole packets instead of >>> just the pointer to the buffer and the buffer's size in order to be able >>> to make use of refcounting to avoid copying of data; this unfortunately >>>

Re: [FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

2019-09-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> 1. Since bd90a2ec, mpeg4_unpack_bframes caches whole packets instead of >> just the pointer to the buffer and the buffer's size in order to be able >> to make use of refcounting to avoid copying of data; this unfortunately >> introduced copies of packet

Re: [FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

2019-09-11 Thread Andreas Rheinhardt
Andreas Rheinhardt: > 1. Since bd90a2ec, mpeg4_unpack_bframes caches whole packets instead of > just the pointer to the buffer and the buffer's size in order to be able > to make use of refcounting to avoid copying of data; this unfortunately > introduced copies of packet structures and side data

[FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

2019-07-10 Thread Andreas Rheinhardt
1. Since bd90a2ec, mpeg4_unpack_bframes caches whole packets instead of just the pointer to the buffer and the buffer's size in order to be able to make use of refcounting to avoid copying of data; this unfortunately introduced copies of packet structures and side data (if existing), although the