Re: [FFmpeg-devel] [PATCH 1/2] x86/vf_blend: Move multiplying to a macro

[Paul B Mahol]

On 2/9/16, Timothy Gu  wrote:
> ---
>  libavfilter/x86/vf_blend.asm | 16 ++--
>  1 file changed, 10 insertions(+), 6 deletions(-)
>

ok
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] x86/vf_blend: Move multiplying to a macro

[Timothy Gu]

On Wed, Feb 10, 2016 at 08:09:07PM +0100, Paul B Mahol wrote:
> On 2/9/16, Timothy Gu  wrote:
> > ---
> >  libavfilter/x86/vf_blend.asm | 16 ++--
> >  1 file changed, 10 insertions(+), 6 deletions(-)
> >
> 
> ok

Pushed.

Timothy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] x86/vf_blend: Move multiplying to a macro

[Timothy Gu]

---
 libavfilter/x86/vf_blend.asm | 16 ++--
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/libavfilter/x86/vf_blend.asm b/libavfilter/x86/vf_blend.asm
index 9388a74..50b5f8a 100644
--- a/libavfilter/x86/vf_blend.asm
+++ b/libavfilter/x86/vf_blend.asm
@@ -102,6 +102,15 @@ BLEND_INIT difference128, 4
 jl .loop
 BLEND_END
 
+%macro MULTIPLY 3 ; a, b, pw_1
+pmullw  %1, %2   ;   a * b
+paddw   %1, %3
+mova%2, %1
+psrlw   %2, 8
+paddw   %1, %2
+psrlw   %1, 8; 00xx00xx  a * b / 255
+%endmacro
+
 BLEND_INIT multiply, 4
 pxor   m2, m2
 mova   m3, [pw_1]
@@ -116,12 +125,7 @@ BLEND_INIT multiply, 4
 punpcklbw   m0, m2   ; 00xx00xx
 punpcklbw   m1, m2
 
-pmullw  m0, m1   ;   a * b
-paddw   m0, m3
-movam1, m0
-psrlw   m1, 8
-paddw   m0, m1
-psrlw   m0, 8; 00xx00xx  a * b / 255
+MULTIPLYm0, m1, m3
 
 packuswbm0, m0   ; 
 movh   [dstq + xq], m0
-- 
1.9.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel