Re: [FFmpeg-devel] [PATCH 1/3] avcodec/qdm2: Do not read out of array in fix_coding_method_array()

2019-07-08 Thread Michael Niedermayer
On Mon, Jun 24, 2019 at 02:09:57PM +0200, Moritz Barsnick wrote: > On Mon, Jun 24, 2019 at 01:01:02 +0200, Michael Niedermayer wrote: > > +if (sb + (j + k) / 64 > 29) { > [...] > > if (coding_method[ch][sb + (j + k) / 64][(j + k) % 64] > > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/qdm2: Do not read out of array in fix_coding_method_array()

2019-06-24 Thread Moritz Barsnick
On Mon, Jun 24, 2019 at 01:01:02 +0200, Michael Niedermayer wrote: > +if (sb + (j + k) / 64 > 29) { [...] > if (coding_method[ch][sb + (j + k) / 64][(j + k) % 64] > > coding_method[ch][sb][j]) { You could do the "sb + (j + k) / 64]" calculation only once

[FFmpeg-devel] [PATCH 1/3] avcodec/qdm2: Do not read out of array in fix_coding_method_array()

2019-06-23 Thread Michael Niedermayer
Instead we ask for a sample, its unclear what to do in this case. Fixes: index 30 out of bounds for type 'int8_t [30][64]' Fixes: 15339/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5749441484554240 Found-by: continuous fuzzing process