Re: [FFmpeg-devel] [PATCH 1/3] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-07-12 Thread Michael Niedermayer
On Tue, Jul 12, 2016 at 03:41:38PM -0700, Jon Toohill wrote: > I'm having a hard time finding software that uses this via simple GitHub > searches. FFmpeg itself uses it > > I think this should be considered a bugfix, since the struct field states > that it only represents encoder delay, not

Re: [FFmpeg-devel] [PATCH 1/3] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-07-12 Thread Jon Toohill
I'm having a hard time finding software that uses this via simple GitHub searches. I think this should be considered a bugfix, since the struct field states that it only represents encoder delay, not decoder delay. I'll send out an updated patchset that splits this into more patches, including

Re: [FFmpeg-devel] [PATCH 1/3] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-06-17 Thread Michael Niedermayer
On Thu, Jun 16, 2016 at 11:16:05AM -0700, Jon Toohill wrote: > Also removes decoder delay compensation from libmp3lame and mp3enc. > initial_padding specifies only encoder delay, decoder delay is > handled by start_skip_samples. > --- > libavcodec/libmp3lame.c | 2 +- > libavformat/mp3dec.c|

[FFmpeg-devel] [PATCH 1/3] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-06-16 Thread Jon Toohill
Also removes decoder delay compensation from libmp3lame and mp3enc. initial_padding specifies only encoder delay, decoder delay is handled by start_skip_samples. --- libavcodec/libmp3lame.c | 2 +- libavformat/mp3dec.c| 2 ++ libavformat/mp3enc.c| 9 ++--- 3 files changed, 9