Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-12-17 Thread Aurelien Jacobs 
On Mon, Nov 06, 2017 at 12:53:38PM -0300, James Almer wrote:
> On 11/5/2017 8:35 PM, Aurelien Jacobs wrote:
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> > ---
> >  doc/general.texi |   2 +
> >  libavcodec/Makefile  |   4 +
> >  libavcodec/allcodecs.c   |   2 +
> >  libavcodec/arm/Makefile  |   3 +
> >  libavcodec/arm/sbcdsp_armv6.S| 245 ++
> >  libavcodec/arm/sbcdsp_init_arm.c | 105 ++
> >  libavcodec/arm/sbcdsp_neon.S | 714 
> > +++
> >  libavcodec/avcodec.h |   2 +
> >  libavcodec/codec_desc.c  |  12 +
> >  libavcodec/sbc.c | 316 +
> >  libavcodec/sbc.h | 121 +++
> >  libavcodec/sbcdec.c  | 469 +
> >  libavcodec/sbcdec_data.c | 127 +++
> >  libavcodec/sbcdec_data.h |  44 +++
> >  libavcodec/sbcdsp.c  | 569 +++
> >  libavcodec/sbcdsp.h  |  86 +
> >  libavcodec/sbcdsp_data.c | 335 ++
> >  libavcodec/sbcdsp_data.h |  57 
> >  libavcodec/sbcenc.c  | 461 +
> >  libavcodec/x86/Makefile  |   2 +
> >  libavcodec/x86/sbcdsp.asm| 290 
> >  libavcodec/x86/sbcdsp_init.c |  51 +++
> >  22 files changed, 4017 insertions(+)
> >  create mode 100644 libavcodec/arm/sbcdsp_armv6.S
> >  create mode 100644 libavcodec/arm/sbcdsp_init_arm.c
> >  create mode 100644 libavcodec/arm/sbcdsp_neon.S
> >  create mode 100644 libavcodec/sbc.c
> >  create mode 100644 libavcodec/sbc.h
> >  create mode 100644 libavcodec/sbcdec.c
> >  create mode 100644 libavcodec/sbcdec_data.c
> >  create mode 100644 libavcodec/sbcdec_data.h
> >  create mode 100644 libavcodec/sbcdsp.c
> >  create mode 100644 libavcodec/sbcdsp.h
> >  create mode 100644 libavcodec/sbcdsp_data.c
> >  create mode 100644 libavcodec/sbcdsp_data.h
> >  create mode 100644 libavcodec/sbcenc.c
> >  create mode 100644 libavcodec/x86/sbcdsp.asm
> >  create mode 100644 libavcodec/x86/sbcdsp_init.c
> 
> This needs to be split into at least four patches.
> One to add the decoder (plus codec ID, descriptor and such things), one
> to add the encoder (and the dsp framework), one to add the x86 assembly
> optimizations for the encoder, and one for the arm optimizations.

OK. New patchset is split this way.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-12-17 Thread Aurelien Jacobs 
On Mon, Nov 06, 2017 at 04:40:56AM +, Rostislav Pehlivanov wrote:
> On 5 November 2017 at 23:35, Aurelien Jacobs  wrote:
> 
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> > ---
> >  doc/general.texi |   2 +
> >  libavcodec/Makefile  |   4 +
> >  libavcodec/allcodecs.c   |   2 +
> >  libavcodec/arm/Makefile  |   3 +
> >  libavcodec/arm/sbcdsp_armv6.S| 245 ++
> >  libavcodec/arm/sbcdsp_init_arm.c | 105 ++
> >  libavcodec/arm/sbcdsp_neon.S | 714 ++
> > +
> >  libavcodec/avcodec.h |   2 +
> >  libavcodec/codec_desc.c  |  12 +
> >  libavcodec/sbc.c | 316 +
> >  libavcodec/sbc.h | 121 +++
> >  libavcodec/sbcdec.c  | 469 +
> >  libavcodec/sbcdec_data.c | 127 +++
> >  libavcodec/sbcdec_data.h |  44 +++
> >  libavcodec/sbcdsp.c  | 569 +++
> >  libavcodec/sbcdsp.h  |  86 +
> >  libavcodec/sbcdsp_data.c | 335 ++
> >  libavcodec/sbcdsp_data.h |  57 
> >  libavcodec/sbcenc.c  | 461 +
> >  libavcodec/x86/Makefile  |   2 +
> >  libavcodec/x86/sbcdsp.asm| 290 
> >  libavcodec/x86/sbcdsp_init.c |  51 +++
> >  22 files changed, 4017 insertions(+)
> >  create mode 100644 libavcodec/arm/sbcdsp_armv6.S
> >  create mode 100644 libavcodec/arm/sbcdsp_init_arm.c
> >  create mode 100644 libavcodec/arm/sbcdsp_neon.S
> >  create mode 100644 libavcodec/sbc.c
> >  create mode 100644 libavcodec/sbc.h
> >  create mode 100644 libavcodec/sbcdec.c
> >  create mode 100644 libavcodec/sbcdec_data.c
> >  create mode 100644 libavcodec/sbcdec_data.h
> >  create mode 100644 libavcodec/sbcdsp.c
> >  create mode 100644 libavcodec/sbcdsp.h
> >  create mode 100644 libavcodec/sbcdsp_data.c
> >  create mode 100644 libavcodec/sbcdsp_data.h
> >  create mode 100644 libavcodec/sbcenc.c
> >  create mode 100644 libavcodec/x86/sbcdsp.asm
> >  create mode 100644 libavcodec/x86/sbcdsp_init.c
> >
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index c4134424f0..2d541bf64a 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -632,6 +632,8 @@ enum AVCodecID {
> >  AV_CODEC_ID_ATRAC3AL,
> >  AV_CODEC_ID_ATRAC3PAL,
> >  AV_CODEC_ID_DOLBY_E,
> > +AV_CODEC_ID_SBC,
> > +AV_CODEC_ID_MSBC,
> >
> >
> See below.
> 
> 
> >  /* subtitle codecs */
> >  AV_CODEC_ID_FIRST_SUBTITLE = 0x17000,  ///< A dummy ID
> > pointing at the start of subtitle codecs.
> > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
> > index 92bf1d2681..8d613507e0 100644
> > --- a/libavcodec/codec_desc.c
> > +++ b/libavcodec/codec_desc.c
> > @@ -2859,6 +2859,18 @@ static const AVCodecDescriptor codec_descriptors[]
> > = {
> >  .long_name = NULL_IF_CONFIG_SMALL("ADPCM MTAF"),
> >  .props = AV_CODEC_PROP_LOSSY,
> >  },
> > +{
> > +.id= AV_CODEC_ID_SBC,
> > +.type  = AVMEDIA_TYPE_AUDIO,
> > +.name  = "sbc",
> > +.long_name = NULL_IF_CONFIG_SMALL("SBC (low-complexity subband
> > codec)"),
> > +},
> > +{
> > +.id= AV_CODEC_ID_MSBC,
> > +.type  = AVMEDIA_TYPE_AUDIO,
> > +.name  = "msbc",
> > +.long_name = NULL_IF_CONFIG_SMALL("mSBC (wideband speech mono
> > SBC)"),
> > +},
> >
> 
> Is there a bitstream difference between the two? I don't think so, so you
> should instead define FF_PROFILE_SBC_WB and use a single codec ID.

SBC support various samplerates while mSBC is limited to 16 kHz.
I think the only way to declare this properly and to get automatic
conversion to 16 kHz when encoding to mSBC is to have 2 separate
codec ID.
So I kept the 2 separate codec ID.

> > diff --git a/libavcodec/sbc.c b/libavcodec/sbc.c
> > new file mode 100644
> > index 00..99d02cc56a
> > --- /dev/null
> > +++ b/libavcodec/sbc.c
> > @@ -0,0 +1,316 @@
> > +/*
> > + * Bluetooth low-complexity, subband codec (SBC)
> > + *
> > + * Copyright (C) 2017  Aurelien Jacobs 
> > + * Copyright (C) 2012-2013  Intel Corporation
> > + * Copyright (C) 2008-2010  Nokia Corporation
> > + * Copyright (C) 2004-2010  Marcel Holtmann 
> > + * Copyright (C) 2004-2005  Henryk Ploetz 
> > + * Copyright (C) 2005-2008  Brad Midgley 
> > + *
> > + * This file is part of FFmpeg.
> > + *
> > + * FFmpeg is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU Lesser General Public
> > + * License as published by the Free Software Foundation; either
> > + * version 2.1 of the License, or (at your option) any later version.
> > + *
> > + * FFmpeg is distributed in the hope

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-12-17 Thread Aurelien Jacobs 
On Mon, Nov 06, 2017 at 04:22:30AM +0100, Michael Niedermayer wrote:
> Hi 
> 
> On Mon, Nov 06, 2017 at 12:35:18AM +0100, Aurelien Jacobs wrote:
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> > ---
> >  doc/general.texi |   2 +
> >  libavcodec/Makefile  |   4 +
> >  libavcodec/allcodecs.c   |   2 +
> >  libavcodec/arm/Makefile  |   3 +
> >  libavcodec/arm/sbcdsp_armv6.S| 245 ++
> >  libavcodec/arm/sbcdsp_init_arm.c | 105 ++
> >  libavcodec/arm/sbcdsp_neon.S | 714 
> > +++
> >  libavcodec/avcodec.h |   2 +
> >  libavcodec/codec_desc.c  |  12 +
> >  libavcodec/sbc.c | 316 +
> >  libavcodec/sbc.h | 121 +++
> >  libavcodec/sbcdec.c  | 469 +
> >  libavcodec/sbcdec_data.c | 127 +++
> >  libavcodec/sbcdec_data.h |  44 +++
> >  libavcodec/sbcdsp.c  | 569 +++
> >  libavcodec/sbcdsp.h  |  86 +
> >  libavcodec/sbcdsp_data.c | 335 ++
> >  libavcodec/sbcdsp_data.h |  57 
> >  libavcodec/sbcenc.c  | 461 +
> >  libavcodec/x86/Makefile  |   2 +
> >  libavcodec/x86/sbcdsp.asm| 290 
> >  libavcodec/x86/sbcdsp_init.c |  51 +++
> >  22 files changed, 4017 insertions(+)
> >  create mode 100644 libavcodec/arm/sbcdsp_armv6.S
> >  create mode 100644 libavcodec/arm/sbcdsp_init_arm.c
> >  create mode 100644 libavcodec/arm/sbcdsp_neon.S
> >  create mode 100644 libavcodec/sbc.c
> >  create mode 100644 libavcodec/sbc.h
> >  create mode 100644 libavcodec/sbcdec.c
> >  create mode 100644 libavcodec/sbcdec_data.c
> >  create mode 100644 libavcodec/sbcdec_data.h
> >  create mode 100644 libavcodec/sbcdsp.c
> >  create mode 100644 libavcodec/sbcdsp.h
> >  create mode 100644 libavcodec/sbcdsp_data.c
> >  create mode 100644 libavcodec/sbcdsp_data.h
> >  create mode 100644 libavcodec/sbcenc.c
> >  create mode 100644 libavcodec/x86/sbcdsp.asm
> >  create mode 100644 libavcodec/x86/sbcdsp_init.c
> 
> this seems to fail to build on x86-32

Ooops... Haven't use x86-32 for so long that it didn't even occured to
me to test it.

> libavcodec/x86/sbcdsp_init.o
> src/libavcodec/x86/sbcdsp.asm:251: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:264: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:267: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:269: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:270: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:271: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:273: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:274: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:275: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:276: error: invalid operands in non-64-bit mode
> STRIP   libavcodec/x86/opus_pvq_search.o

Fixed in upcoming patchset.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-11-06 Thread James Almer 
On 11/5/2017 8:35 PM, Aurelien Jacobs wrote:
> This was originally based on libsbc, and was fully integrated into ffmpeg.
> ---
>  doc/general.texi |   2 +
>  libavcodec/Makefile  |   4 +
>  libavcodec/allcodecs.c   |   2 +
>  libavcodec/arm/Makefile  |   3 +
>  libavcodec/arm/sbcdsp_armv6.S| 245 ++
>  libavcodec/arm/sbcdsp_init_arm.c | 105 ++
>  libavcodec/arm/sbcdsp_neon.S | 714 
> +++
>  libavcodec/avcodec.h |   2 +
>  libavcodec/codec_desc.c  |  12 +
>  libavcodec/sbc.c | 316 +
>  libavcodec/sbc.h | 121 +++
>  libavcodec/sbcdec.c  | 469 +
>  libavcodec/sbcdec_data.c | 127 +++
>  libavcodec/sbcdec_data.h |  44 +++
>  libavcodec/sbcdsp.c  | 569 +++
>  libavcodec/sbcdsp.h  |  86 +
>  libavcodec/sbcdsp_data.c | 335 ++
>  libavcodec/sbcdsp_data.h |  57 
>  libavcodec/sbcenc.c  | 461 +
>  libavcodec/x86/Makefile  |   2 +
>  libavcodec/x86/sbcdsp.asm| 290 
>  libavcodec/x86/sbcdsp_init.c |  51 +++
>  22 files changed, 4017 insertions(+)
>  create mode 100644 libavcodec/arm/sbcdsp_armv6.S
>  create mode 100644 libavcodec/arm/sbcdsp_init_arm.c
>  create mode 100644 libavcodec/arm/sbcdsp_neon.S
>  create mode 100644 libavcodec/sbc.c
>  create mode 100644 libavcodec/sbc.h
>  create mode 100644 libavcodec/sbcdec.c
>  create mode 100644 libavcodec/sbcdec_data.c
>  create mode 100644 libavcodec/sbcdec_data.h
>  create mode 100644 libavcodec/sbcdsp.c
>  create mode 100644 libavcodec/sbcdsp.h
>  create mode 100644 libavcodec/sbcdsp_data.c
>  create mode 100644 libavcodec/sbcdsp_data.h
>  create mode 100644 libavcodec/sbcenc.c
>  create mode 100644 libavcodec/x86/sbcdsp.asm
>  create mode 100644 libavcodec/x86/sbcdsp_init.c

This needs to be split into at least four patches.
One to add the decoder (plus codec ID, descriptor and such things), one
to add the encoder (and the dsp framework), one to add the x86 assembly
optimizations for the encoder, and one for the arm optimizations.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-11-06 Thread James Almer 
On 11/6/2017 9:53 AM, Carl Eugen Hoyos wrote:
> 2017-11-06 5:40 GMT+01:00 Rostislav Pehlivanov :
> 
>>> +{
>>> +.id= AV_CODEC_ID_SBC,
>>> +.type  = AVMEDIA_TYPE_AUDIO,
>>> +.name  = "sbc",
>>> +.long_name = NULL_IF_CONFIG_SMALL("SBC (low-complexity subband
>>> codec)"),
>>> +},
>>> +{
>>> +.id= AV_CODEC_ID_MSBC,
>>> +.type  = AVMEDIA_TYPE_AUDIO,
>>> +.name  = "msbc",
>>> +.long_name = NULL_IF_CONFIG_SMALL("mSBC (wideband speech mono
>>> SBC)"),
>>> +},
>>>
>>
>> Is there a bitstream difference between the two? I don't think so, so you
>> should instead define FF_PROFILE_SBC_WB and use a single codec ID.
> 
> Would that have an advantage?
> 
> One day, somebody will it into isom and define two different codec_tags...

DTS audio has a lot of different codec tags in isom, including DTS-E
which is a completely different bitstream altogether, and we have a
single codec ID for them all.

The de/muxer can handle it just fine, so it's not an issue.

> 
> Carl Eugen
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-11-06 Thread Carl Eugen Hoyos 
2017-11-06 5:40 GMT+01:00 Rostislav Pehlivanov :

>> +{
>> +.id= AV_CODEC_ID_SBC,
>> +.type  = AVMEDIA_TYPE_AUDIO,
>> +.name  = "sbc",
>> +.long_name = NULL_IF_CONFIG_SMALL("SBC (low-complexity subband
>> codec)"),
>> +},
>> +{
>> +.id= AV_CODEC_ID_MSBC,
>> +.type  = AVMEDIA_TYPE_AUDIO,
>> +.name  = "msbc",
>> +.long_name = NULL_IF_CONFIG_SMALL("mSBC (wideband speech mono
>> SBC)"),
>> +},
>>
>
> Is there a bitstream difference between the two? I don't think so, so you
> should instead define FF_PROFILE_SBC_WB and use a single codec ID.

Would that have an advantage?

One day, somebody will it into isom and define two different codec_tags...

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-11-05 Thread Rostislav Pehlivanov 
On 5 November 2017 at 23:35, Aurelien Jacobs  wrote:

> This was originally based on libsbc, and was fully integrated into ffmpeg.
> ---
>  doc/general.texi |   2 +
>  libavcodec/Makefile  |   4 +
>  libavcodec/allcodecs.c   |   2 +
>  libavcodec/arm/Makefile  |   3 +
>  libavcodec/arm/sbcdsp_armv6.S| 245 ++
>  libavcodec/arm/sbcdsp_init_arm.c | 105 ++
>  libavcodec/arm/sbcdsp_neon.S | 714 ++
> +
>  libavcodec/avcodec.h |   2 +
>  libavcodec/codec_desc.c  |  12 +
>  libavcodec/sbc.c | 316 +
>  libavcodec/sbc.h | 121 +++
>  libavcodec/sbcdec.c  | 469 +
>  libavcodec/sbcdec_data.c | 127 +++
>  libavcodec/sbcdec_data.h |  44 +++
>  libavcodec/sbcdsp.c  | 569 +++
>  libavcodec/sbcdsp.h  |  86 +
>  libavcodec/sbcdsp_data.c | 335 ++
>  libavcodec/sbcdsp_data.h |  57 
>  libavcodec/sbcenc.c  | 461 +
>  libavcodec/x86/Makefile  |   2 +
>  libavcodec/x86/sbcdsp.asm| 290 
>  libavcodec/x86/sbcdsp_init.c |  51 +++
>  22 files changed, 4017 insertions(+)
>  create mode 100644 libavcodec/arm/sbcdsp_armv6.S
>  create mode 100644 libavcodec/arm/sbcdsp_init_arm.c
>  create mode 100644 libavcodec/arm/sbcdsp_neon.S
>  create mode 100644 libavcodec/sbc.c
>  create mode 100644 libavcodec/sbc.h
>  create mode 100644 libavcodec/sbcdec.c
>  create mode 100644 libavcodec/sbcdec_data.c
>  create mode 100644 libavcodec/sbcdec_data.h
>  create mode 100644 libavcodec/sbcdsp.c
>  create mode 100644 libavcodec/sbcdsp.h
>  create mode 100644 libavcodec/sbcdsp_data.c
>  create mode 100644 libavcodec/sbcdsp_data.h
>  create mode 100644 libavcodec/sbcenc.c
>  create mode 100644 libavcodec/x86/sbcdsp.asm
>  create mode 100644 libavcodec/x86/sbcdsp_init.c
>
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index c4134424f0..2d541bf64a 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -632,6 +632,8 @@ enum AVCodecID {
>  AV_CODEC_ID_ATRAC3AL,
>  AV_CODEC_ID_ATRAC3PAL,
>  AV_CODEC_ID_DOLBY_E,
> +AV_CODEC_ID_SBC,
> +AV_CODEC_ID_MSBC,
>
>
See below.


>  /* subtitle codecs */
>  AV_CODEC_ID_FIRST_SUBTITLE = 0x17000,  ///< A dummy ID
> pointing at the start of subtitle codecs.
> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
> index 92bf1d2681..8d613507e0 100644
> --- a/libavcodec/codec_desc.c
> +++ b/libavcodec/codec_desc.c
> @@ -2859,6 +2859,18 @@ static const AVCodecDescriptor codec_descriptors[]
> = {
>  .long_name = NULL_IF_CONFIG_SMALL("ADPCM MTAF"),
>  .props = AV_CODEC_PROP_LOSSY,
>  },
> +{
> +.id= AV_CODEC_ID_SBC,
> +.type  = AVMEDIA_TYPE_AUDIO,
> +.name  = "sbc",
> +.long_name = NULL_IF_CONFIG_SMALL("SBC (low-complexity subband
> codec)"),
> +},
> +{
> +.id= AV_CODEC_ID_MSBC,
> +.type  = AVMEDIA_TYPE_AUDIO,
> +.name  = "msbc",
> +.long_name = NULL_IF_CONFIG_SMALL("mSBC (wideband speech mono
> SBC)"),
> +},
>

Is there a bitstream difference between the two? I don't think so, so you
should instead define FF_PROFILE_SBC_WB and use a single codec ID.


>
>  /* subtitle codecs */
>  {
> diff --git a/libavcodec/sbc.c b/libavcodec/sbc.c
> new file mode 100644
> index 00..99d02cc56a
> --- /dev/null
> +++ b/libavcodec/sbc.c
> @@ -0,0 +1,316 @@
> +/*
> + * Bluetooth low-complexity, subband codec (SBC)
> + *
> + * Copyright (C) 2017  Aurelien Jacobs 
> + * Copyright (C) 2012-2013  Intel Corporation
> + * Copyright (C) 2008-2010  Nokia Corporation
> + * Copyright (C) 2004-2010  Marcel Holtmann 
> + * Copyright (C) 2004-2005  Henryk Ploetz 
> + * Copyright (C) 2005-2008  Brad Midgley 
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> 02110-1301 USA
> + */
> +
> +/**
> + * @file
> + * SBC common

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-11-05 Thread Michael Niedermayer 
Hi 

On Mon, Nov 06, 2017 at 12:35:18AM +0100, Aurelien Jacobs wrote:
> This was originally based on libsbc, and was fully integrated into ffmpeg.
> ---
>  doc/general.texi |   2 +
>  libavcodec/Makefile  |   4 +
>  libavcodec/allcodecs.c   |   2 +
>  libavcodec/arm/Makefile  |   3 +
>  libavcodec/arm/sbcdsp_armv6.S| 245 ++
>  libavcodec/arm/sbcdsp_init_arm.c | 105 ++
>  libavcodec/arm/sbcdsp_neon.S | 714 
> +++
>  libavcodec/avcodec.h |   2 +
>  libavcodec/codec_desc.c  |  12 +
>  libavcodec/sbc.c | 316 +
>  libavcodec/sbc.h | 121 +++
>  libavcodec/sbcdec.c  | 469 +
>  libavcodec/sbcdec_data.c | 127 +++
>  libavcodec/sbcdec_data.h |  44 +++
>  libavcodec/sbcdsp.c  | 569 +++
>  libavcodec/sbcdsp.h  |  86 +
>  libavcodec/sbcdsp_data.c | 335 ++
>  libavcodec/sbcdsp_data.h |  57 
>  libavcodec/sbcenc.c  | 461 +
>  libavcodec/x86/Makefile  |   2 +
>  libavcodec/x86/sbcdsp.asm| 290 
>  libavcodec/x86/sbcdsp_init.c |  51 +++
>  22 files changed, 4017 insertions(+)
>  create mode 100644 libavcodec/arm/sbcdsp_armv6.S
>  create mode 100644 libavcodec/arm/sbcdsp_init_arm.c
>  create mode 100644 libavcodec/arm/sbcdsp_neon.S
>  create mode 100644 libavcodec/sbc.c
>  create mode 100644 libavcodec/sbc.h
>  create mode 100644 libavcodec/sbcdec.c
>  create mode 100644 libavcodec/sbcdec_data.c
>  create mode 100644 libavcodec/sbcdec_data.h
>  create mode 100644 libavcodec/sbcdsp.c
>  create mode 100644 libavcodec/sbcdsp.h
>  create mode 100644 libavcodec/sbcdsp_data.c
>  create mode 100644 libavcodec/sbcdsp_data.h
>  create mode 100644 libavcodec/sbcenc.c
>  create mode 100644 libavcodec/x86/sbcdsp.asm
>  create mode 100644 libavcodec/x86/sbcdsp_init.c

this seems to fail to build on x86-32

libavcodec/x86/sbcdsp_init.o
src/libavcodec/x86/sbcdsp.asm:251: error: invalid operands in non-64-bit mode
src/libavcodec/x86/sbcdsp.asm:264: error: invalid operands in non-64-bit mode
src/libavcodec/x86/sbcdsp.asm:267: error: invalid operands in non-64-bit mode
src/libavcodec/x86/sbcdsp.asm:269: error: invalid operands in non-64-bit mode
src/libavcodec/x86/sbcdsp.asm:270: error: invalid operands in non-64-bit mode
src/libavcodec/x86/sbcdsp.asm:271: error: invalid operands in non-64-bit mode
src/libavcodec/x86/sbcdsp.asm:273: error: invalid operands in non-64-bit mode
src/libavcodec/x86/sbcdsp.asm:274: error: invalid operands in non-64-bit mode
src/libavcodec/x86/sbcdsp.asm:275: error: invalid operands in non-64-bit mode
src/libavcodec/x86/sbcdsp.asm:276: error: invalid operands in non-64-bit mode
STRIP   libavcodec/x86/opus_pvq_search.o


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel