Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Michael Niedermayer
On Fri, Dec 07, 2018 at 01:43:37PM +0100, Hendrik Leppkes wrote: > On Fri, Dec 7, 2018 at 1:15 PM Paul B Mahol wrote: > > > > On 12/7/18, Michael Niedermayer wrote: > > > On Fri, Dec 07, 2018 at 11:21:57AM +0100, Paul B Mahol wrote: > > >> On 12/7/18, Michael Niedermayer wrote: > > >> > On Fri,

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Hendrik Leppkes
On Fri, Dec 7, 2018 at 1:15 PM Paul B Mahol wrote: > > On 12/7/18, Michael Niedermayer wrote: > > On Fri, Dec 07, 2018 at 11:21:57AM +0100, Paul B Mahol wrote: > >> On 12/7/18, Michael Niedermayer wrote: > >> > On Fri, Dec 07, 2018 at 10:28:09AM +0100, Paul B Mahol wrote: > >> >> On 12/7/18,

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Paul B Mahol
On 12/7/18, Michael Niedermayer wrote: > On Fri, Dec 07, 2018 at 11:21:57AM +0100, Paul B Mahol wrote: >> On 12/7/18, Michael Niedermayer wrote: >> > On Fri, Dec 07, 2018 at 10:28:09AM +0100, Paul B Mahol wrote: >> >> On 12/7/18, Michael Niedermayer wrote: >> >> > On Wed, Dec 05, 2018 at

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Michael Niedermayer
On Fri, Dec 07, 2018 at 11:21:57AM +0100, Paul B Mahol wrote: > On 12/7/18, Michael Niedermayer wrote: > > On Fri, Dec 07, 2018 at 10:28:09AM +0100, Paul B Mahol wrote: > >> On 12/7/18, Michael Niedermayer wrote: > >> > On Wed, Dec 05, 2018 at 09:22:48PM +0100, Paul B Mahol wrote: > >> >>

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Paul B Mahol
On 12/7/18, Michael Niedermayer wrote: > On Fri, Dec 07, 2018 at 10:28:09AM +0100, Paul B Mahol wrote: >> On 12/7/18, Michael Niedermayer wrote: >> > On Wed, Dec 05, 2018 at 09:22:48PM +0100, Paul B Mahol wrote: >> >> Signed-off-by: Paul B Mahol >> >> --- >> >> libavcodec/proresdec2.c | 51 >>

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Michael Niedermayer
On Fri, Dec 07, 2018 at 10:28:09AM +0100, Paul B Mahol wrote: > On 12/7/18, Michael Niedermayer wrote: > > On Wed, Dec 05, 2018 at 09:22:48PM +0100, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/proresdec2.c | 51 ++--- > >> 1

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Paul B Mahol
On 12/7/18, Michael Niedermayer wrote: > On Wed, Dec 05, 2018 at 09:22:48PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/proresdec2.c | 51 ++--- >> 1 file changed, 27 insertions(+), 24 deletions(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-07 Thread Michael Niedermayer
On Wed, Dec 05, 2018 at 09:22:48PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/proresdec2.c | 51 ++--- > 1 file changed, 27 insertions(+), 24 deletions(-) > > diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-05 Thread Carl Eugen Hoyos
2018-12-05 19:00 GMT+01:00, Gregor Riepl : > There seems to be an indentation issue here: This is intended to allow an actual review. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-05 Thread Carl Eugen Hoyos
2018-12-05 21:22 GMT+01:00, Paul B Mahol : > Signed-off-by: Paul B Mahol > --- > libavcodec/proresdec2.c | 51 ++--- > 1 file changed, 27 insertions(+), 24 deletions(-) > > diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c > index

[FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/proresdec2.c | 51 ++--- 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c index 8581d797fb..80a76bbba1 100644 --- a/libavcodec/proresdec2.c +++

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-05 Thread Michael Niedermayer
On Wed, Dec 05, 2018 at 06:52:06PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/proresdec2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) breaks make fate-prores-alpha_skip TESTprores-alpha_skip --- ./tests/ref/fate/prores-alpha_skip 2018-12-04

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-05 Thread Gregor Riepl
There seems to be an indentation issue here: > +if (avctx->profile == FF_PROFILE_UNKNOWN) { > switch (avctx->codec_tag) { > case MKTAG('a','p','c','o'): and here: > av_log(avctx, AV_LOG_WARNING, "Unknown prores profile %d\n", > avctx->codec_tag); > } > +}

[FFmpeg-devel] [PATCH 1/4] avcodec/proresdec2: change profile only if it is unknown

2018-12-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/proresdec2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c index 8581d797fb..f715b86aad 100644 --- a/libavcodec/proresdec2.c +++ b/libavcodec/proresdec2.c @@ -140,6 +140,7 @@