Re: [FFmpeg-devel] [PATCH 1/4] lavf/aviobuf: add ff_get_chomp_line

2018-04-12 Thread Jun Zhao
On 2018/4/11 16:52, Marton Balint wrote: > > > On Wed, 11 Apr 2018, Jun Zhao wrote: > >> >> >> On 2018/4/10 21:54, Marton Balint wrote: >>> >>> >>> On Tue, 10 Apr 2018, Jun Zhao wrote: >>> >>> >>> Maybe you should use ff_read_line_to_bprint instead? It already chops >>> the trailing lin

Re: [FFmpeg-devel] [PATCH 1/4] lavf/aviobuf: add ff_get_chomp_line

2018-04-11 Thread Jun Zhao
On 2018/4/11 16:52, Marton Balint wrote: > > > On Wed, 11 Apr 2018, Jun Zhao wrote: > >> >> >> On 2018/4/10 21:54, Marton Balint wrote: >>> >>> >>> On Tue, 10 Apr 2018, Jun Zhao wrote: >>> >>> >>> Maybe you should use ff_read_line_to_bprint instead? It already chops >>> the trailing lin

Re: [FFmpeg-devel] [PATCH 1/4] lavf/aviobuf: add ff_get_chomp_line

2018-04-11 Thread Marton Balint
On Wed, 11 Apr 2018, Jun Zhao wrote: On 2018/4/10 21:54, Marton Balint wrote: On Tue, 10 Apr 2018, Jun Zhao wrote: Maybe you should use ff_read_line_to_bprint instead? It already chops the trailing line endings, not any whitespace though. Generally I think we should deprecate ff_get

Re: [FFmpeg-devel] [PATCH 1/4] lavf/aviobuf: add ff_get_chomp_line

2018-04-10 Thread Jun Zhao
On 2018/4/10 21:54, Marton Balint wrote: > > > On Tue, 10 Apr 2018, Jun Zhao wrote: > >> >> > > Maybe you should use ff_read_line_to_bprint instead? It already chops > the trailing line endings, not any whitespace though. Generally I > think we should deprecate ff_get_line, because line length li

Re: [FFmpeg-devel] [PATCH 1/4] lavf/aviobuf: add ff_get_chomp_line

2018-04-10 Thread Marton Balint
On Tue, 10 Apr 2018, Jun Zhao wrote: Maybe you should use ff_read_line_to_bprint instead? It already chops the trailing line endings, not any whitespace though. Generally I think we should deprecate ff_get_line, because line length limits always pop here or there... Regards, Marton __

Re: [FFmpeg-devel] [PATCH 1/4] lavf/aviobuf: add ff_get_chomp_line

2018-04-09 Thread Steven Liu
> On 10 Apr 2018, at 08:33, Jun Zhao wrote: > > > <0001-lavf-aviobuf-add-ff_get_chomp_line.patch>___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel patchset LGTM Thanks Steven __

[FFmpeg-devel] [PATCH 1/4] lavf/aviobuf: add ff_get_chomp_line

2018-04-09 Thread Jun Zhao
From 58e8cb520eeeb727ee834ee81877db7c81fe089b Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Mon, 9 Apr 2018 23:05:42 +0800 Subject: [PATCH 1/4] lavf/aviobuf: add ff_get_chomp_line Same as ff_get_line but strip the white-space characters in the string tail. Signed-off-by: Jun Zhao --- libavfor