Re: [FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

2023-05-02 Thread Nicolas George
Rémi Denis-Courmont (12023-05-02): > So it must be very poorly written because C union are supposed to avoid this > cleanly. > If you need padding where any sane implementation does not, then it is > clearly > poorly written. I must say, I am impressed by the rudeness and arrogance of such a

Re: [FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

2023-05-02 Thread Rémi Denis-Courmont
Le tiistaina 2. toukokuuta 2023, 19.42.39 EEST Nicolas George a écrit : > Rémi Denis-Courmont (12023-05-02): > > A JSON writer that requires forced alignment is a poorly-written JSON > > parser. > This JSON writer requires that the structures that contain its state are > aligned, just like any

Re: [FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

2023-05-02 Thread Nicolas George
Rémi Denis-Courmont (12023-05-02): > A JSON writer that requires forced alignment is a poorly-written JSON parser. This JSON writer requires that the structures that contain its state are aligned, just like any other piece of C code. There is nothing poorly-written here. > This is reinventing

Re: [FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

2023-05-02 Thread Rémi Denis-Courmont
Le perjantaina 28. huhtikuuta 2023, 12.55.01 EEST Nicolas George a écrit : > Signed-off-by: Nicolas George > --- > libavutil/extendable.h | 59 ++ > 1 file changed, 59 insertions(+) > create mode 100644 libavutil/extendable.h > > > FFReservedPadding is

Re: [FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

2023-04-29 Thread Derek Buitenhuis
On 4/29/2023 9:17 AM, Anton Khirnov wrote: > What important problem within the scope of the project is being solved > by this? Why do we need over a 1000 lines of just new header files for > it? Why do we need a generic JSON writer? We are not a JSON library. > Neither are we a string processing

Re: [FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

2023-04-29 Thread Anton Khirnov
I've said this before, repeating it again for ease of reference: I do not believe the use case for this has been sufficiently established. What important problem within the scope of the project is being solved by this? Why do we need over a 1000 lines of just new header files for it? Why do we

[FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

2023-04-28 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/extendable.h | 59 ++ 1 file changed, 59 insertions(+) create mode 100644 libavutil/extendable.h FFReservedPadding is used by the WIP JSON writer. diff --git a/libavutil/extendable.h b/libavutil/extendable.h