Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Aaron, Comments inline: > > Most of the changes in this set of patches appear to only be relevant in the > case that libklvanc is enabled. Nevertheless, a number of the changes are > not wrapped in #if CONFIG_LIBKLVANC, which means that they will be exercised > even if libklvanc is not

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line construction is

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

2017-12-29 22:00 GMT+01:00 Devin Heitmueller : > I’m not discounting your concerns - just there isn’t much I can do about > them but continue to try to improve the quality of the code until it’s > reliable enough for wider adoption. :-) Thank you for the comments!

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Carl, Thanks for your feedback. Comments inline> > On Dec 29, 2017, at 3:41 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > >> +side_data = av_frame_get_side_data(pic, AV_FRAME_DATA_A53_CC); >> +if

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > +side_data = av_frame_get_side_data(pic, AV_FRAME_DATA_A53_CC); > +if (side_data && side_data->size) { > +uint8_t *buf = av_packet_new_side_data(pkt, AV_PKT_DATA_A53_CC, > side_data->size); > +if

[FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line construction is done by libklvanc. Libklvanc can be found at: