Re: [FFmpeg-devel] [PATCH 11/37] avformat/matroskadec: Improve read error/EOF checks I

2019-06-23 Thread Andreas Rheinhardt
James Almer: > On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: >> ebml_read_num had a number of flaws: >> >> 1. The check for read errors/EOF was totally wrong. E.g. an EBML number >> beginning with the invalid 0x00 would be considered a read error, >> although it is just invalid data. >> 2. The

Re: [FFmpeg-devel] [PATCH 11/37] avformat/matroskadec: Improve read error/EOF checks I

2019-06-23 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > ebml_read_num had a number of flaws: > > 1. The check for read errors/EOF was totally wrong. E.g. an EBML number > beginning with the invalid 0x00 would be considered a read error, > although it is just invalid data. > 2. The check for read

[FFmpeg-devel] [PATCH 11/37] avformat/matroskadec: Improve read error/EOF checks I

2019-05-16 Thread Andreas Rheinhardt
ebml_read_num had a number of flaws: 1. The check for read errors/EOF was totally wrong. E.g. an EBML number beginning with the invalid 0x00 would be considered a read error, although it is just invalid data. 2. The check for read errors/EOF was done just once, after reading the first byte of the