Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pnm: Avoid structure pointer dereferences in inner loop in pnm_get()

2019-02-22 Thread Michael Niedermayer
On Fri, Feb 22, 2019 at 09:10:55AM +0200, Lauri Kasanen wrote: > On Thu, 21 Feb 2019 20:34:29 +0100 > Michael Niedermayer wrote: > > > Improves speed from 5.4 to 4.2 seconds > > Fixes: > > 13149/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGM_fuzzer-5760833622114304 > > LGTM will apply

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pnm: Avoid structure pointer dereferences in inner loop in pnm_get()

2019-02-21 Thread Lauri Kasanen
On Thu, 21 Feb 2019 20:34:29 +0100 Michael Niedermayer wrote: > Improves speed from 5.4 to 4.2 seconds > Fixes: > 13149/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGM_fuzzer-5760833622114304 LGTM Though, I really would expect the compiler to detect and optimize that. I wonder if

[FFmpeg-devel] [PATCH 2/2] avcodec/pnm: Avoid structure pointer dereferences in inner loop in pnm_get()

2019-02-21 Thread Michael Niedermayer
Improves speed from 5.4 to 4.2 seconds Fixes: 13149/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGM_fuzzer-5760833622114304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pnm.c | 15