Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2017-09-26 Thread wm4
On Mon, 25 Sep 2017 11:49:51 -0700 Aman Gupta wrote: > On Mon, Sep 25, 2017 at 3:06 AM, wm4 wrote: > > > On Mon, 25 Sep 2017 09:02:36 +0200 > > Hendrik Leppkes wrote: > > > > > On Mon, Sep 25, 2017 at 3:31 AM, Aman Gupta wrote: > > > > > > > > How do the other hwaccels handle mid-stream S

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2017-09-25 Thread Aman Gupta
On Mon, Sep 25, 2017 at 3:06 AM, wm4 wrote: > On Mon, 25 Sep 2017 09:02:36 +0200 > Hendrik Leppkes wrote: > > > On Mon, Sep 25, 2017 at 3:31 AM, Aman Gupta wrote: > > > > > > How do the other hwaccels handle mid-stream SPS changes? > > > > > > > Real HWAccels (ie. VAAPI, VDPAU or DXVA) communic

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2017-09-25 Thread wm4
On Mon, 25 Sep 2017 09:02:36 +0200 Hendrik Leppkes wrote: > On Mon, Sep 25, 2017 at 3:31 AM, Aman Gupta wrote: > > > > How do the other hwaccels handle mid-stream SPS changes? > > > > Real HWAccels (ie. VAAPI, VDPAU or DXVA) communicate the SPS/PPS > content for every frame, they don't keep a

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2017-09-25 Thread Hendrik Leppkes
On Mon, Sep 25, 2017 at 3:31 AM, Aman Gupta wrote: > > How do the other hwaccels handle mid-stream SPS changes? > Real HWAccels (ie. VAAPI, VDPAU or DXVA) communicate the SPS/PPS content for every frame, they don't keep a persistent state internally - that way the only "state" is the frame size a

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2017-09-24 Thread Aman Gupta
On Thu, Oct 1, 2015 at 9:54 AM, wm4 wrote: > On Thu, 1 Oct 2015 18:45:40 +0200 > Hendrik Leppkes wrote: > > > On Thu, Oct 1, 2015 at 6:39 PM, wm4 wrote: > > > On Thu, 1 Oct 2015 18:29:00 +0200 > > > Hendrik Leppkes wrote: > > > > > >> On Thu, Oct 1, 2015 at 6:13 PM, wm4 wrote: > > >> > This a

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2015-10-02 Thread wm4
On Thu, 1 Oct 2015 18:13:21 +0200 wm4 wrote: > This affects Annex B streams (such as demuxed from .ts and others). It > also handles the format change in reinit-large_420_8-to-small_420_8.h264 > correctly. > > Instead of passing through the extradata, create it on the fly it from > the currentl

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2015-10-01 Thread wm4
On Thu, 1 Oct 2015 18:45:40 +0200 Hendrik Leppkes wrote: > On Thu, Oct 1, 2015 at 6:39 PM, wm4 wrote: > > On Thu, 1 Oct 2015 18:29:00 +0200 > > Hendrik Leppkes wrote: > > > >> On Thu, Oct 1, 2015 at 6:13 PM, wm4 wrote: > >> > This affects Annex B streams (such as demuxed from .ts and others).

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2015-10-01 Thread Hendrik Leppkes
On Thu, Oct 1, 2015 at 6:39 PM, wm4 wrote: > On Thu, 1 Oct 2015 18:29:00 +0200 > Hendrik Leppkes wrote: > >> On Thu, Oct 1, 2015 at 6:13 PM, wm4 wrote: >> > This affects Annex B streams (such as demuxed from .ts and others). It >> > also handles the format change in reinit-large_420_8-to-small_4

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2015-10-01 Thread wm4
On Thu, 1 Oct 2015 18:29:00 +0200 Hendrik Leppkes wrote: > On Thu, Oct 1, 2015 at 6:13 PM, wm4 wrote: > > This affects Annex B streams (such as demuxed from .ts and others). It > > also handles the format change in reinit-large_420_8-to-small_420_8.h264 > > correctly. > > > > Instead of passing

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2015-10-01 Thread Hendrik Leppkes
On Thu, Oct 1, 2015 at 6:13 PM, wm4 wrote: > This affects Annex B streams (such as demuxed from .ts and others). It > also handles the format change in reinit-large_420_8-to-small_420_8.h264 > correctly. > > Instead of passing through the extradata, create it on the fly it from > the currently act

[FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2015-10-01 Thread wm4
This affects Annex B streams (such as demuxed from .ts and others). It also handles the format change in reinit-large_420_8-to-small_420_8.h264 correctly. Instead of passing through the extradata, create it on the fly it from the currently active SPS and PPS. Since reconstructing the PPS and SPS N