Re: [FFmpeg-devel] [PATCH 2/2] opts: add list device sources/sinks options

2014-10-25 Thread Lukasz Marek
On 24.10.2014 23:13, Michael Niedermayer wrote: +The returned list cannot be assumed to be always completed. complete +The returned list cannot be assumed to be always completed. complete Both changed i wonder if some of the code can be factorized/simplifed but either way it LGTM I know

Re: [FFmpeg-devel] [PATCH 2/2] opts: add list device sources/sinks options

2014-10-24 Thread Michael Niedermayer
On Fri, Oct 24, 2014 at 10:08:21PM +0200, Lukasz Marek wrote: On 22.10.2014 02:02, Michael Niedermayer wrote: it seems the only use of this function is under #if CONFIG_AVDEVICE so the fallback shouldnt be needed same for the other function also mising documentation and example in docs

Re: [FFmpeg-devel] [PATCH 2/2] opts: add list device sources/sinks options

2014-10-21 Thread Lukasz Marek
On 19.10.2014 00:20, Michael Niedermayer wrote: On Sat, Oct 18, 2014 at 08:25:30PM +0200, Lukasz Marek wrote: Allows to list sources/sinks of the devices that implement that functionality. Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com [...] +int show_sinks(void *optctx, const char

Re: [FFmpeg-devel] [PATCH 2/2] opts: add list device sources/sinks options

2014-10-21 Thread Michael Niedermayer
On Sat, Oct 18, 2014 at 08:25:30PM +0200, Lukasz Marek wrote: Allows to list sources/sinks of the devices that implement that functionality. Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com --- cmdutils.c | 191 +

[FFmpeg-devel] [PATCH 2/2] opts: add list device sources/sinks options

2014-10-18 Thread Lukasz Marek
Allows to list sources/sinks of the devices that implement that functionality. Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com --- cmdutils.c | 191 + cmdutils.h | 12 cmdutils_common_opts.h | 6 ++ 3 files

Re: [FFmpeg-devel] [PATCH 2/2] opts: add list device sources/sinks options

2014-10-18 Thread Michael Niedermayer
On Sat, Oct 18, 2014 at 08:25:30PM +0200, Lukasz Marek wrote: Allows to list sources/sinks of the devices that implement that functionality. Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com [...] +int show_sinks(void *optctx, const char *opt, const char *arg) +{ +#if CONFIG_AVDEVICE +