Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-02-04 Thread Marton Balint
On Sat, 2 Feb 2019, Michael Niedermayer wrote: On Fri, Feb 01, 2019 at 10:29:13PM +0100, Marton Balint wrote: On Fri, 25 Jan 2019, Marton Balint wrote: On Fri, 25 Jan 2019, Michael Niedermayer wrote: On Thu, Jan 24, 2019 at 09:38:00PM +0100, Marton Balint wrote: discard_pid can be

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-02-01 Thread Michael Niedermayer
On Fri, Feb 01, 2019 at 10:29:13PM +0100, Marton Balint wrote: > > > On Fri, 25 Jan 2019, Marton Balint wrote: > > > > > > >On Fri, 25 Jan 2019, Michael Niedermayer wrote: > > > >>On Thu, Jan 24, 2019 at 09:38:00PM +0100, Marton Balint wrote: > >>>discard_pid can be quite expensive, so let's

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-02-01 Thread Marton Balint
On Fri, 25 Jan 2019, Marton Balint wrote: On Fri, 25 Jan 2019, Michael Niedermayer wrote: On Thu, Jan 24, 2019 at 09:38:00PM +0100, Marton Balint wrote: discard_pid can be quite expensive, so let's cache it and recalculate it on every packet start. ffmpeg -y -i

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-01-25 Thread Marton Balint
On Fri, 25 Jan 2019, Michael Niedermayer wrote: On Thu, Jan 24, 2019 at 09:38:00PM +0100, Marton Balint wrote: discard_pid can be quite expensive, so let's cache it and recalculate it on every packet start. ffmpeg -y -i samples/MPEG-VOB/sdtv/RAI.ts -c copy -map 0:v:0 -map 0:a:0 -f mpegts

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-01-25 Thread Michael Niedermayer
On Thu, Jan 24, 2019 at 09:38:00PM +0100, Marton Balint wrote: > discard_pid can be quite expensive, so let's cache it and recalculate it on > every packet start. > > ffmpeg -y -i samples/MPEG-VOB/sdtv/RAI.ts -c copy -map 0:v:0 -map 0:a:0 -f > mpegts /dev/null > > Before: >1685 decicycles

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-01-24 Thread Carl Eugen Hoyos
2019-01-24 21:38 GMT+01:00, Marton Balint : > discard_pid can be quite expensive, so let's cache it and recalculate it on > every packet start. > > ffmpeg -y -i samples/MPEG-VOB/sdtv/RAI.ts -c copy -map 0:v:0 -map 0:a:0 > -f mpegts /dev/null I can reproduce a 30% overall speedup for this command

[FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-01-24 Thread Marton Balint
discard_pid can be quite expensive, so let's cache it and recalculate it on every packet start. ffmpeg -y -i samples/MPEG-VOB/sdtv/RAI.ts -c copy -map 0:v:0 -map 0:a:0 -f mpegts /dev/null Before: 1685 decicycles in handle_packet, 523483 runs,805 skips After: 883 decicycles in