Re: [FFmpeg-devel] [PATCH 2/3] lavf/avio: temporarily accept 0 as EOF.

2017-10-29 Thread Jan Ekstrom
On Fri, Oct 27, 2017 at 9:56 PM, Jan Ekstrom wrote: > On Fri, Oct 27, 2017 at 9:46 PM, Nicolas George wrote: >> Print a warning to let applicatios fix their use. >> After a deprecation period, check with a low-level assert. >> Also make the constraint explicit

Re: [FFmpeg-devel] [PATCH 2/3] lavf/avio: temporarily accept 0 as EOF.

2017-10-27 Thread Jan Ekstrom
On Fri, Oct 27, 2017 at 9:46 PM, Nicolas George wrote: > Print a warning to let applicatios fix their use. > After a deprecation period, check with a low-level assert. > Also make the constraint explicit in the doxygen comment. Difference to the previous version: > -

[FFmpeg-devel] [PATCH 2/3] lavf/avio: temporarily accept 0 as EOF.

2017-10-27 Thread Nicolas George
Print a warning to let applicatios fix their use. After a deprecation period, check with a low-level assert. Also make the constraint explicit in the doxygen comment. Signed-off-by: Nicolas George --- libavformat/avio.h| 2 ++ libavformat/aviobuf.c | 30

Re: [FFmpeg-devel] [PATCH 2/3] lavf/avio: temporarily accept 0 as EOF.

2017-10-27 Thread Jan Ekstrom
On Fri, Oct 27, 2017 at 9:33 PM, Nicolas George wrote: > It is standard parlance in networking: stream protocols produce a stream > of octets, without any additional structure, while packet protocols > produce packets, which are delimited at protocol level and visible by > the

Re: [FFmpeg-devel] [PATCH 2/3] lavf/avio: temporarily accept 0 as EOF.

2017-10-27 Thread Nicolas George
Le sextidi 6 brumaire, an CCXXVI, Jan Ekstrom a écrit : > Otherwise OK, but since this is the first mention of "stream protocol" > in the repo and el goog gives me just "Internet Stream Protocol" so I > would like an explanation of what this means and how it connects to > "custom AVIO

Re: [FFmpeg-devel] [PATCH 2/3] lavf/avio: temporarily accept 0 as EOF.

2017-10-27 Thread Nicolas George
Le sextidi 6 brumaire, an CCXXVI, Jan Ekstrom a écrit : > Built and tested locally and the effect seems to be the one wished, > although it seems like it is complaining about the AVClass being > nullptr? Is this something inherent to custom AVIO contexts and it's > the client that's supposed to

Re: [FFmpeg-devel] [PATCH 2/3] lavf/avio: temporarily accept 0 as EOF.

2017-10-27 Thread Jan Ekstrom
On Wed, Oct 25, 2017 at 11:22 AM, Nicolas George wrote: > +static int read_packet_wrapper(AVIOContext *s, uint8_t *buf, int size) > +{ > +int ret; > + > +if (!s->read_packet) > +return AVERROR_EOF; > +ret = s->read_packet(s->opaque, buf, size); > +#if

Re: [FFmpeg-devel] [PATCH 2/3] lavf/avio: temporarily accept 0 as EOF.

2017-10-27 Thread Jan Ekstrom
On Wed, Oct 25, 2017 at 11:22 AM, Nicolas George wrote: > Print a warning to let applicatios fix their use. > After a deprecation period, check with a low-level assert. > Also make the constraint explicit in the doxygen comment. > > Signed-off-by: Nicolas George

[FFmpeg-devel] [PATCH 2/3] lavf/avio: temporarily accept 0 as EOF.

2017-10-25 Thread Nicolas George
Print a warning to let applicatios fix their use. After a deprecation period, check with a low-level assert. Also make the constraint explicit in the doxygen comment. Signed-off-by: Nicolas George --- libavformat/avio.h| 2 ++ libavformat/aviobuf.c | 30